Fix bugs initializing stretched and pasted tables. - #190
Open
btrewern wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issues with the table tool’s “stretched” mode not being applied correctly on initial render and behaving incorrectly after pasting tables, by syncing the tool’s persisted data.stretched state with the Editor.js block’s stretched UI state.
Changes:
- Adds a post-render hook to apply
data.stretchedto the Editor.js block once the block is mounted. - Centralizes tune activation handling via
_updateTunes()and triggers a block change dispatch when tunes are toggled. - Ensures pasted table data includes a
stretchedfield (but currently resets it unconditionally).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
250
to
254
| this.data = { | ||
| withHeadings: firstRowHeading !== null, | ||
| stretched: false, | ||
| content | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following:
(using stretched-fix branch)