Feat/rh forge UI target - #8
Merged
Merged
Conversation
RHAI-760 and RHAI-761 matched no keyword in config/repo_mapping.json, so resolve_target_repo() returned "" and both epics would have been skipped silently — the failure mode 91692dc already cost us once. The right target, rh-forge/rh-forge-ui, is private. The shared bot cannot reach it and cannot be given a seat. Swapping --fork-owner globally would work, but it would also put a person's name on every other strategy's PRs, which is what ADR-0030 exists to prevent. So identity is resolved per target repo instead: a mapping entry may carry fork_owner and gh_token_var, and identity_for_repo() is the single resolver behind all eight GitHub call sites. our_user follows fork_owner, or the review loop reads the author's own comments as feedback and answers itself forever. The mapping holds the variable *name*; the credential is read from the environment at the point of use. ederign/openc-ui-by-agentic-sdlc is retired rather than repointed — same product lineage (its package.json name is literally forge-ui), strategy Closed, and its keywords carry forward to the live repo. Cloning the target then exposed a gate that was lying. rh-forge-ui is pnpm with engine-strict=true and Node ^24.15.0 || >=26; the CI image was Node 22 with no pnpm, and preflight still reported ok: true, because it recognised yarn.lock and nothing else. _discover_js_commands had the matching gap, hardcoding `npm run lint` regardless of what the repo declared. Together that is exactly the environment-fault-scored-as-bad-code ADR-0025 was written for. detect_package_manager() is now the single answer, preflight gates on it, and Dockerfile.ci moves to Node 26 with pnpm via corepack — `corepack enable pnpm`, not a bare `corepack enable`, which would shadow the yarn odh-dashboard needs. Also commits the work ledger itself (AGENTS.md, docs/, check_ledger.py), which was sitting uncommitted in the tree; ADR-0035 and this change's task and bug entries live inside it, so they could not land separately. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The fix landed in cf130f7; the ledger requires a fixed bug to cite what closed it, which is not knowable until the commit exists. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.