Skip to content

[cleanup] Use only one border node description provider for all item border nodes - #2431

Merged
AxelRICHARD merged 2 commits into
mainfrom
gco/cleanup/item-border-nodes
Aug 17, 2026
Merged

[cleanup] Use only one border node description provider for all item border nodes#2431
AxelRICHARD merged 2 commits into
mainfrom
gco/cleanup/item-border-nodes

Conversation

@gcoutable

@gcoutable gcoutable commented Aug 17, 2026

Copy link
Copy Markdown
Member
  • [cleanup] Use ViewEdgeToolService to create edge tools in AbstractItemUsageBorderNodeDescriptionProvider
  • [cleanup] Use only one border node description provider for all item border nodes

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@gcoutable gcoutable added this to the 2026.9.0 milestone Aug 17, 2026
@gcoutable
gcoutable force-pushed the gco/cleanup/item-border-nodes branch 2 times, most recently from ec95596 to 9046e37 Compare August 17, 2026 08:04
@gcoutable
gcoutable marked this pull request as ready for review August 17, 2026 08:05
@gcoutable
gcoutable requested a review from AxelRICHARD August 17, 2026 08:06
@gcoutable
gcoutable force-pushed the gco/cleanup/item-border-nodes branch from 9046e37 to 33244e7 Compare August 17, 2026 08:51
…mUsageBorderNodeDescriptionProvider

Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
…border nodes

Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@AxelRICHARD
AxelRICHARD force-pushed the gco/cleanup/item-border-nodes branch from 33244e7 to dac152f Compare August 17, 2026 09:29
@AxelRICHARD
AxelRICHARD merged commit 6fe873a into main Aug 17, 2026
4 checks passed
@AxelRICHARD
AxelRICHARD deleted the gco/cleanup/item-border-nodes branch August 17, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants