Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.text.quicksearch/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.text.quicksearch;singleton:=true
Bundle-Version: 1.3.500.qualifier
Bundle-Version: 1.3.600.qualifier
Bundle-Activator: org.eclipse.text.quicksearch.internal.ui.QuickSearchActivator
Require-Bundle: org.eclipse.ui;bundle-version="[3.113.0,4.0.0)",
org.eclipse.core.resources;bundle-version="[3.13.0,4.0.0)",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,7 @@ public void update(ViewerCell cell) {

private SourceViewer viewer;
private LineNumberRulerColumn lineNumberColumn;
private SourceViewerDecorationSupport sourceViewerDecorationSupport;
private FixedLineHighlighter targetLineHighlighter;
private final IPropertyChangeListener preferenceChangeListener = this::handlePropertyChangeEvent;

Expand Down Expand Up @@ -561,26 +562,7 @@ public void run() {
*/
@Override
public boolean close() {
this.progressJob.cancel();
this.progressJob = null;
// this.refreshProgressMessageJob.cancel();
if (showViewHandler != null) {
IHandlerService service = PlatformUI
.getWorkbench().getService(IHandlerService.class);
service.deactivateHandler(showViewHandler);
showViewHandler.getHandler().dispose();
showViewHandler = null;
}
if (menuManager != null) {
menuManager.dispose();
}
if (contextMenuManager != null) {
contextMenuManager.dispose();
}
storeDialog(getDialogSettings());
if (searcher!=null) {
searcher.cancel();
}
return super.close();
}

Expand Down Expand Up @@ -1015,6 +997,32 @@ private Composite createNestedComposite(Composite parent, int numRows, boolean e
}

protected void dispose() {
if (progressJob != null) {
progressJob.cancel();
progressJob = null;
}
if (showViewHandler != null) {
IHandlerService service = PlatformUI.getWorkbench().getService(IHandlerService.class);
service.deactivateHandler(showViewHandler);
showViewHandler.getHandler().dispose();
showViewHandler = null;
}
if (menuManager != null) {
menuManager.dispose();
menuManager = null;
}
if (contextMenuManager != null) {
contextMenuManager.dispose();
contextMenuManager = null;
}
if (searcher != null) {
searcher.cancel();
searcher = null;
}
if (sourceViewerDecorationSupport != null) {
sourceViewerDecorationSupport.dispose();
sourceViewerDecorationSupport = null;
}
if (blankImage!=null) {
blankImage.dispose();
blankImage = null;
Expand Down Expand Up @@ -1086,7 +1094,7 @@ private void createViewerDecorations() {
lineNumberColumn.setForeground(getLineNumbersColor());
viewer.addVerticalRulerColumn(lineNumberColumn);

var sourceViewerDecorationSupport = new SourceViewerDecorationSupport(viewer, null, null, EditorsUI.getSharedTextColors());
sourceViewerDecorationSupport = new SourceViewerDecorationSupport(viewer, null, null, EditorsUI.getSharedTextColors());
sourceViewerDecorationSupport.setCursorLinePainterPreferenceKeys(EDITOR_CURRENT_LINE, EDITOR_CURRENT_LINE_COLOR);
sourceViewerDecorationSupport.install(EditorsUI.getPreferenceStore());
targetLineHighlighter = new FixedLineHighlighter();
Expand Down
Loading