Simplify return type of positionTooltip(NMHDR, long) - #3497
Merged
HeikoKlare merged 1 commit intoAug 11, 2026
Merged
Conversation
Contributor
Author
|
Ping @HeikoKlare |
r-mennig
changed the title
Use boolean return type instead of LRESULT in positionTooltip(NMHDR, long) since the current implementation only ever returns LRESULT.ONE or null. Relates to eclipse-platform#3491
r-mennig
force-pushed
the
cleanup_positionTooltip_return_value
branch
from
August 10, 2026 16:02
ed43eea to
e36c0ac
Compare
Contributor
HeikoKlare
approved these changes
Aug 11, 2026
HeikoKlare
left a comment
HeikoKlare
left a comment
Contributor
There was a problem hiding this comment.
As discussed in #3491 that's a reasonable clean-up. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #3487 (comment), simplifying the return type of
Table.positionTooltip(NMHDR hdr, long lParam).This changes the methods return type to
booleaninstead ofLRESULTsince the current implementation only ever returnsLRESULT.ONEornull.Relates to #3491