Repository navigation
[Build] Run the image entrypoint in smoke-test pods - #4126
Merged
HannesWell merged 1 commit intoOct 29, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the smoke-test change that initializes the container user before starting the keepalive command.
No open issues 🎉
What changed in this PR
Updates smoke-test pods to run the image’s uid_entrypoint, allowing it to register the arbitrary OpenShift user in /etc/passwd before starting cat. This addresses the missing user entry that prevents D-Bus session startup and triggers SWT warnings.
Changes:
- Replaces the direct
catcommand withuid_entrypoint, passingcatas its argument. - Preserves the existing TTY and container resource settings.
| File | Description |
|---|---|
jobs/builds/smoke-tests.jenkinsfile |
Runs the image’s UID initialization before the smoke-test container’s keepalive command. |
Review effort: Balanced
The pod's command 'cat' replaced the image's uid_entrypoint, so the arbitrary OpenShift user never got an /etc/passwd entry. Without it dbus-launch can't autolaunch a session bus on X11, and SWT warns that it cannot connect to the session manager. Run uid_entrypoint with 'cat' as its argument. This and the previous fixes of the docker images, allows to remove the disablement of the SWT DBus Sessionmanager via the SWT_SESSIONMANAGER_DBUS_DISABLE environment variable.
HannesWell
force-pushed
the
smoke-tests-uid-entrypoint
branch
from
October 29, 2026 21:57
45cb004 to
a537ab4
Compare
HannesWell
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pod's command 'cat' replaced the image's uid_entrypoint, so the arbitrary OpenShift user never got an /etc/passwd entry. Without it dbus-launch can't autolaunch a session bus on X11, and SWT warns that it cannot connect to the session manager.
Run uid_entrypoint with 'cat' as its argument.