Skip to content

Develop 2.5.2 - #13

Draft
al3xwq wants to merge 1 commit into
masterfrom
develop-2.5.2
Draft

Develop 2.5.2#13
al3xwq wants to merge 1 commit into
masterfrom
develop-2.5.2

feat: updated to 2.5.2

26a952a
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jul 29, 2026 in 16s

Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

Annotations

Check warning on line 88 in src/main/cpp/CardTerminal.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the misleading "/*" characters. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZUpfxzSpa6on4wr&open=AZoBqZUpfxzSpa6on4wr&pullRequest=13

Check warning on line 44 in src/main/cpp/TerminalFactory.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this "const" qualifier from the return type in all declarations. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZSkfxzSpa6on4wS&open=AZoBqZSkfxzSpa6on4wS&pullRequest=13

Check failure on line 100 in src/main/cpp/CardTerminals.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the "nullptr" literal. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZTkfxzSpa6on4wd&open=AZoBqZTkfxzSpa6on4wd&pullRequest=13

Check warning on line 66 in src/main/PcscReaderAdapter.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "mDisconnectionMode". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZWBfxzSpa6on4wy&open=AZoBqZWBfxzSpa6on4wy&pullRequest=13

Check warning on line 51 in src/main/PcscPluginAdapter.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "mIsCardTerminalsInitialized". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZVhfxzSpa6on4wx&open=AZoBqZVhfxzSpa6on4wx&pullRequest=13

Check warning on line 268 in include/keyple/plugin/pcsc/PcscReaderAdapter.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the "final" specifier by "override". 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZXIfxzSpa6on4w9&open=AZoBqZXIfxzSpa6on4w9&pullRequest=13

Check warning on line 313 in include/keyple/plugin/pcsc/PcscReader.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce verbosity with "using enum" for "keyple::plugin::pcsc::PcscReader::DisconnectionMode". 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZYxfxzSpa6on4xB&open=AZoBqZYxfxzSpa6on4xB&pullRequest=13

Check warning on line 151 in src/main/cpp/CardTerminal.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoLZCAzhs8gUniZafzJ&open=AZoLZCAzhs8gUniZafzJ&pullRequest=13

Check warning on line 303 in src/main/PcscReaderAdapter.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Handle this exception or don't catch it at all. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZWCfxzSpa6on4w1&open=AZoBqZWCfxzSpa6on4w1&pullRequest=13

Check failure on line 115 in src/main/cpp/CardTerminals.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the "nullptr" literal. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZTkfxzSpa6on4wf&open=AZoBqZTkfxzSpa6on4wf&pullRequest=13

Check warning on line 122 in src/main/cpp/CardChannel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto". 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZT5fxzSpa6on4wp&open=AZoBqZT5fxzSpa6on4wp&pullRequest=13

Check warning on line 85 in src/main/cpp/Card.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this "const" qualifier from the return type in all declarations. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZU-fxzSpa6on4wv&open=AZoBqZU-fxzSpa6on4wv&pullRequest=13

Check warning on line 37 in src/main/cpp/TerminalFactory.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::make_shared" to construct "std::shared_ptr". 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZSkfxzSpa6on4wR&open=AZoBqZSkfxzSpa6on4wR&pullRequest=13

Check warning on line 62 in src/main/cpp/CardChannel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto". 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZT5fxzSpa6on4wk&open=AZoBqZT5fxzSpa6on4wk&pullRequest=13

Check warning on line 475 in src/main/PcscReaderAdapter.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZWCfxzSpa6on4w3&open=AZoBqZWCfxzSpa6on4w3&pullRequest=13

Check warning on line 73 in src/main/cpp/CardTerminals.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this const reference to "std::string" by a "std::string_view". 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZTkfxzSpa6on4wZ&open=AZoBqZTkfxzSpa6on4wZ&pullRequest=13

Check warning on line 505 in src/main/PcscReaderAdapter.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZWCfxzSpa6on4w5&open=AZoBqZWCfxzSpa6on4w5&pullRequest=13

Check warning on line 258 in include/keyple/plugin/pcsc/PcscReaderAdapter.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the "final" specifier by "override". 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZXIfxzSpa6on4w8&open=AZoBqZXIfxzSpa6on4w8&pullRequest=13

Check warning on line 33 in src/main/cpp/CardChannel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "mIsClosed". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZT5fxzSpa6on4wh&open=AZoBqZT5fxzSpa6on4wh&pullRequest=13

Check warning on line 282 in src/main/PcscReaderAdapter.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce verbosity with "using enum" for "keyple::plugin::pcsc::PcscReader::DisconnectionMode". 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZWBfxzSpa6on4w0&open=AZoBqZWBfxzSpa6on4w0&pullRequest=13

Check failure on line 91 in src/main/cpp/TerminalFactory.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZSkfxzSpa6on4wT&open=AZoBqZSkfxzSpa6on4wT&pullRequest=13

Check warning on line 89 in src/main/cpp/Card.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::string" instead of a C-style char array. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZU-fxzSpa6on4ww&open=AZoBqZU-fxzSpa6on4ww&pullRequest=13

Check warning on line 51 in src/main/cpp/CardTerminals.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use std::format instead of concatenating pieces manually. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZTkfxzSpa6on4wY&open=AZoBqZTkfxzSpa6on4wY&pullRequest=13

Check failure on line 84 in include/keyple/plugin/pcsc/cpp/CardTerminals.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "explicit" keyword to this constructor. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZXufxzSpa6on4w_&open=AZoBqZXufxzSpa6on4w_&pullRequest=13

Check warning on line 91 in src/main/cpp/CardTerminal.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code. 

See more on https://sonarcloud.io/project/issues?id=eclipse-keyple_keyple-plugin-pcsc-cpp-lib&issues=AZoBqZUpfxzSpa6on4wt&open=AZoBqZUpfxzSpa6on4wt&pullRequest=13
View more details on SonarQubeCloud