Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tolusha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi! I'm che-ai-assistant — I help with your pull requests. I check for new comments every 10m0s, so there may be a short delay before I respond. Available commands:
|
|
/che-ai-assistant claude Resolve conflicts Task completed. |
✅ Merge conflicts resolvedMerged the latest Safety check: the requested action ("resolve conflicts") is non-destructive. It was done via a merge commit (no rebase, no history rewrite) and a regular fast-forward push ( Conflicts (3 files)
Notes
Performed with Claude Code. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2184 +/- ##
==========================================
- Coverage 52.84% 52.29% -0.55%
==========================================
Files 119 122 +3
Lines 15052 15254 +202
==========================================
+ Hits 7954 7977 +23
- Misses 6562 6737 +175
- Partials 536 540 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
| ContainerRegistry CheClusterContainerRegistry `json:"containerRegistry"` | ||
| // AI agent runtime sandbox configuration. | ||
| // +optional | ||
| AgentRuntimes *AgentRuntimes `json:"agentRuntimes,omitempty"` |
There was a problem hiding this comment.
from the semantics perspective shouldn't we use AgentSandbox - https://agent-sandbox.sigs.k8s.io/docs/getting_started/overview/ ?
| Namespace string `json:"namespace,omitempty"` | ||
| // runtimeClassName applied to the managed sandbox pod. | ||
| // +optional | ||
| RuntimeClassName string `json:"runtimeClassName,omitempty"` |
| // hanging this value after creation orphans the Sandbox in the previous namespace; | ||
| // disable the feature before changing it so the old Sandbox is cleaned up first. | ||
| // +optional | ||
| Namespace string `json:"namespace,omitempty"` |
There was a problem hiding this comment.
Is it about namespace where Sandbox CR objects are created, e.g. we expect all of them created in a single namespace?
| RuntimeClassName string `json:"runtimeClassName,omitempty"` | ||
| // Container image for the managed agent runtime sandbox pod. | ||
| // +optional | ||
| Image string `json:"image,omitempty"` |
There was a problem hiding this comment.
I'm a bit lost tbh, reading CR definition feels like we are dealing with a single Sandbox instance whereas there could be multiple Sandboxes created per-user similar to CDEs
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
This PR contains changes to files in directories that are typically not intended to be committed:
Please verify these changes are intentional. |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-arm64 |
|
New operator image available: quay.io/eclipse/che-operator:pr-2184-amd64 |
|
@tolusha: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
What does this PR do?
Implements Phase 2 of agent runtimes support (eclipse-che/che#23921).
This PR adds support for AgentSandbox integration.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#23921
How to test this PR?
OpenShift
Edit the CheCluster CR to enable the agent sandbox:
oc patch checluster eclipse-che -n eclipse-che --type=merge -p '{"spec":{"agentSandbox":{"enabled": true}}}'
Check that user has permission manipulate with Sandbox resources in a workspace
Common Test Scenarios
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.