server: Add sdk dependency and build docker images from /server - #611
Open
hpoeche wants to merge 3 commits into
Open
server: Add sdk dependency and build docker images from /server#611hpoeche wants to merge 3 commits into
hpoeche wants to merge 3 commits into
Conversation
The sdk was not listed as dependency of the server package although it is used in the server extensively. As we have for now no proper cross-package dependency defninition strategy, we apply the same workaround as with the compliance_tool. As the server is never released as package to PyPI but only install in docker image builds, this can be considered as appropiate temporary solution.
Previously the docker builds needed the repository root as build context in order to copy the content of sdk and server directory. In order to isolate the server package in its `/server` subpath, the build now uses this directory as context. The sdk sources are passed via an additional build context. CI jobs, docker-compose.yml files and Readmes are adapted accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server package uses the sdk extensively but never declared it as a dependency, and its Docker
builds required the repository root as build context, which is awkward for isolating the server
package in its own subpath.
basyx-python-sdkas an explicit dependency of the server package, using the samecommit-pinning workaround already applied to
compliance_tool. This is only a temporary fixuntil proper cross-package dependency definitions are figured out in Adopt a proper cross-package dependency strategy for the monorepo (evaluate
uvworkspaces) #592, which should beconsidered next.
./serveras build context instead of the repository root,passing the sdk sources in via a separate named build context.
Fixes #459
Fixes #470