Restructure versions to a single point of truth - #610
Open
JAB1305 wants to merge 7 commits into
Open
Conversation
Previously, version pins for Python, `mypy`, `ruff`, and the API/spec
versions lived in multiple places: workflow env blocks, three
`pyproject.toml` files, `ruff.toml`, and the server Dockerfiles.
`mypy` was pinned in the SDK but unpinned in the server and
compliance tool, and `ruff` was not pinned anywhere.
Bumping any of these values required editing several files and
was easy to get wrong.
This change introduces a repo-root `versions.yaml` as the single
source of truth. A new `check_global_versions_coincide.py`
verifies that every listed `pyproject.toml`, `config.yaml`, and
Dockerfile coincides with the yaml. New entries under `dev_tools`
are checked automatically without further script changes. A
composite action `.github/actions/load-versions` exposes the
values to CI jobs as `X_*` environment variables so consuming
workflows keep their existing `${{ env.X_* }}` usage.
Runtime server constants (currently only `api_base_path`) live in
a separate `server/config.yaml`, read by the server directly at
import time.
The old `check_python_versions_coincide.py` is superseded and
removed.
Fixes eclipse-basyx#548
JAB1305
marked this pull request as ready for review
August 9, 2026 15:41
JAB1305
marked this pull request as draft
August 10, 2026 08:23
1 task
JAB1305
marked this pull request as ready for review
August 12, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, version pins for Python,
mypy,ruff, and the API/spec versions lived in multiple places: workflow env blocks, threepyproject.tomlfiles,ruff.toml, and the server Dockerfiles.mypywas pinned in the SDK but unpinned in the server and compliance tool, andruffwas not pinned anywhere.Bumping any of these values required editing several files and was easy to get wrong.
This change introduces a repo-root
versions.tomlas the single source of truth. A newcheck_global_versions_coincide.pyverifies that every listedpyproject.toml,config.yaml, and Dockerfile coincides with the yaml. New entries underdev_toolsare checked automatically without further script changes. A composite action.github/actions/load-versionsexposes the values to CI jobs asX_*environment variables so consuming workflows keep their existing${{ env.X_* }}usage.Runtime server constants (currently only
api_base_path) live in a separateserver/config.toml, read by the server directly at import time.The old
check_python_versions_coincide.pyis superseded and removed.Fixes #548