fix: skip malformed AASX files during AAS Environment startup (#765) - #1056
Closed
mandardharurkar wants to merge 1 commit into
Closed
fix: skip malformed AASX files during AAS Environment startup (#765)#1056mandardharurkar wants to merge 1 commit into
mandardharurkar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Wrapped the per-file AASX loading logic in
AasEnvironmentPreconfigurationLoaderwith a try-catch block. Instead of propagating the exception and crashing the entire AAS Environment, the loader now:This ensures a single corrupt or unsupported AASX file does not prevent the entire environment from starting.
Related Issue
#765
BaSyx Configuration for Testing
No special configuration needed. Default AAS Environment setup works.
To reproduce the original crash (before fix):
After the fix, the same setup logs a warning and continues starting normally.
AAS Files Used for Testing
sample.aasxAdditional Information
AuthorizedAASEnvironmentPreconfigurationLoadersince it extends the base loader and had the same vulnerability.--strictflag to restore the old crash-on-error behavior, but decided to keep the fix minimal per the issue scope.File Location - basyx-java-server-sdk\basyx.aasenvironment\basyx.aasenvironment-core\src\test\resources\org\eclipse\digitaltwin\basyx\aasenvironment\invalid_environment.aasx