Repository navigation
feat(cli): Bedrock, Vertex and Azure probe parity - #52
Merged
Merged
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI probe layer now mirrors the app for the cloud providers, so
hoist keys probeworks for Bedrock, Vertex and Azure OpenAI instead of falling through to no probe implemented. Bedrock probes through the AWS environment chain without a vault key, Vertex reads its stored project and region sibling entries, and Azure resolves its endpoint from AZURE_OPENAI_ENDPOINT.Closes #51
Refs #15
Verification
mise run ci:clipassed in this worktree (bun install, typecheck, the new bun test suite, and the compiled CLI build).mise run ci:apppassed (catalog check, typecheck, lint, unit tests and the full build). App source is untouched in this PR; it was run because the CI script change sits in the shared scripts folder.Export named 'probeBedrock' not found, then passed after the implementation.Proof is from mocked HTTP only, with no live provider keys. The fixture server in the tests records the signed Bedrock request, the Vertex project and region path, and the Azure api-key header.
Built CLI transcript, with the AWS environment cleared and no vault key stored:
The Bedrock line is the point of the wiring change. The probe now reaches the aws probe and reports the missing credential chain, instead of stopping at the vault key check.
Reviewer notes
bun testbetween typecheck and the compiled build, so the new suite gates the CLI release flow.