Repository navigation
feat(keys): store Vertex project and region in the vault - #50
Merged
Merged
Conversation
Add provider config secret ids (provider:vertex:project and provider:vertex:region) beside the api_key id, a pure buildProbeContext helper that prefers explicit probe fields over stored vault values, and IPC wiring that passes stored project and region into runProbe. Bedrock (probeKind aws) no longer needs a vault key to probe, since it reads the AWS env chain. The renderer Keys step now lists Vertex in Add key, asks for project id, region and access token before Save, writes the sibling secrets on save, deletes them with the key, and never renders config entries as key rows. Co-authored-by: Muse Code <muse-code@meta.com>
7 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stores the Vertex GCP project and region in the vault beside the access token and wires them into the probe, so a saved Vertex key can validate through the Keys step. Bedrock can also probe without a vault key, since it reads the AWS env chain.
Closes #49
Refs #15
Verification
mise run ci:apppassed in this worktree (catalog check, typecheck, lint, unit tests including the new secret id and probe context cases, and the full build).mise run ci:clipassed (typecheck and compiled CLI build). The CLI is untouched in this PR, becausecli/src/lib/probes.tsis a separate implementation and CLI parity stays a follow-up in the independent CLI flow.secretIdForProviderConfig is not a functionanddist/main/probes/context.js missing, then passed after the implementation and rebuild.Proof is from a logic-only slice with no live provider keys. The Electron app was not launched for a screenshot in this headless run, so the proof below is the unit test output that runs under
npm test.Reviewer notes
provider:vertex:projectandprovider:vertex:region. They use the same safeStorage backend as the API key, they never render as key rows, and deleting the Vertex key deletes them too.