Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #85
Closes #114
What changed: the catalog no longer defines the same groups and guest user twice. examples/ is now the single source for group:default/readers, group:default/developers, group:default/admins and user:default/guest, as documented in docs/demo-baseline.md. Deleted default-catalog/groups.yaml (only duplicates), removed the three guest User entries from default-catalog/users.yaml (kept the unique johnnyhuy user, still a developers member via examples), and dropped the ./groups.yaml target from default-catalog/catalog-info.yaml. The unique echohello organisation group in organizations.yaml is untouched. Config-only slice, no code or visual change.
How it was verified:
Proof:
Capture method: agent-browser snapshot succeeded, PNG capture was blocked. The agent-browser screenshot command hung and was terminated, so no PNG is attached (same block as the #113 run). The live snapshot is the behaviour proof: signed in as guest, opened /catalog?filters[kind]=group, and the table listed Admins, Developers and Readers exactly once each, served from the deduped catalog with no conflict warnings in the backend log.
Known gaps and follow-ups: