Skip to content

fix(pwa): prevent false reconnect and resolve CodeQL test alert - #540

Merged
hoangsvit merged 2 commits into
stagingfrom
fix/pwa-codeql-manifest-validation-20261120
Nov 20, 2026
Merged

hoangsvit merged 2 commits into
stagingfrom
fix/pwa-codeql-manifest-validation-20261120

Conversation

@hoangsvit

Copy link
Copy Markdown
Member

Follow-up to #536/#539 and blocker for production release #538. Require the exact same-origin OnAir web manifest (name, start URL, scope) before reloading a cached offline page, so an arbitrary JSON response cannot trigger false recovery. Replace the CodeQL-flagged HTML parsing regex in the offline unit-test harness with literal index slicing; this resolves the high-severity Bad HTML filtering regexp alert detected in PR #538 without suppressing the security gate. Update expected test manifest to match the real site. Merging into staging also ensures a website-content push triggers the current-SHA staging Pages deployment. No audio cache, autoplay, analytics or SEO changes.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

ePlus OnAir — PR Preview

🗃️ Preview expired. This PR is closed; the Preview link is hidden.

View build status

Preview is noindex; the full catalog is available on Staging after merge.

@hoangsvit
hoangsvit merged commit 9d27c59 into staging Nov 20, 2026
7 checks passed
@hoangsvit
hoangsvit deleted the fix/pwa-codeql-manifest-validation-20261120 branch November 20, 2026 06:41

This branch was successfully deployed

1 active deployment
preview — 0738c728 Deployed Nov 20, 2026 by hoangsvit via Remove closed PR Preview #551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant