Skip to content

feat(radio): preview updated Mi Amigo Radio JPEG logo - #530

Merged
hoangsvit merged 4 commits into
stagingfrom
feat/mi-amigo-official-png-20261119
Nov 19, 2026
Merged

hoangsvit merged 4 commits into
stagingfrom
feat/mi-amigo-official-png-20261119

Conversation

@hoangsvit

@hoangsvit hoangsvit commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Update Mi Amigo Radio's catalog to use the locally uploaded JPEG artwork at public/img/europe/italy/mi-amigo-radio.jpg.
  • Replace the previous external SVG reference without changing stream, CORS configuration, metadata, or station route.
  • Update the radio regression test to verify the local JPEG's presence and signature.

Why PR #530 initially failed

  • The actual committed asset was mi-amigo-radio.jpg (79,113 bytes, Git blob 67949487cd40dcc338eee2ebfdaae3f0414a1c4e).
  • The catalog and test mistakenly referred to mi-amigo-radio.png, which did not exist.
  • CI and Preview both stopped on ENOENT during the unit test, before prerendering.
  • Corrected those references to .jpg; kept the already uploaded binary untouched.

Checks

  • Reviewed initial CI and Preview failure logs: missing PNG path, not a CORS or playback error.
  • Checked source tree has the JPEG file and no matching PNG.
  • Updated catalog reference and test to match the actual tracked file.
  • Re-run CI and Preview checks for this commit.
  • Visually inspect the uploaded artwork on both light and dark backgrounds, on the station page, cards, and player.
  • Merge to staging after verification; normal staging → main release process remains required.

This PR is a visual logo trial. Do not claim Production is updated until the normal release is complete.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

ePlus OnAir — PR Preview

🗃️ Preview expired. This PR is closed; the Preview link is hidden.

View build status

Preview is noindex; the full catalog is available on Staging after merge.

@hoangsvit
hoangsvit marked this pull request as ready for review November 19, 2026 01:29
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@hoangsvit hoangsvit self-assigned this Nov 19, 2026
@hoangsvit hoangsvit changed the title feat(radio): preview Mi Amigo official 512px PNG logo feat(radio): preview updated Mi Amigo Radio JPEG logo Nov 19, 2026
@hoangsvit
hoangsvit merged commit 75d1667 into staging Nov 19, 2026
18 of 19 checks passed
@hoangsvit
hoangsvit deleted the feat/mi-amigo-official-png-20261119 branch November 19, 2026 02:17

This branch was successfully deployed

1 active deployment
preview — 8b289ba4 Deployed Nov 19, 2026 by hoangsvit via Remove closed PR Preview #537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant