Repository navigation
test: drop Git env vars during unit tests - #216
Merged
Merged
Conversation
`git commit` runs pre-commit hooks with GIT_INDEX_FILE (and friends) exported, pointing at the parent repository's index. That leaks into the nested git subprocesses of tests/unit, whose fresh repositories lack the referenced objects, so their commits die with "Error building trees" and just-unit fails. Scrub the four GIT_* path variables via an autouse fixture so every unit test's Git subprocesses work on their own repositories. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with the unit tests when run by pre-commit after a
git commit -am ...command.