Skip to content

Allow intentional historical PyPI yanks #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmcdaniel merged 1 commit into from
Sep 2, 2026
Merged

Allow intentional historical PyPI yanks #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions scripts/check_pypi_project_surface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,7 @@ def verify_stable_project_json(
if not legacy_versions:
raise ProjectSurfaceError("PyPI project-root JSON no longer retains historical stable 0.x releases")
for version in legacy_versions:
files = _release_files(releases, version)
if any(file.get("yanked") is not False for file in files):
raise ProjectSurfaceError(f"historical release {version} must remain retained and non-yanked")
_release_files(releases, version)

return tuple(legacy_versions)

Expand Down
5 changes: 2 additions & 3 deletions tests/test_pypi_project_surface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,16 +348,15 @@ def resolve(requirement: str, *, prerelease: bool) -> object:
assert evidence["historical_versions"] == ["0.4.105", "0.4.106"]


def test_stable_root_preserves_non_yanked_historical_files() -> None:
def test_stable_root_preserves_historical_files_without_overriding_yanks() -> None:
source = source_metadata(stable=True)
exact_urls = verify_exact_version_json(exact_version_payload(source), source)

assert verify_stable_project_json(stable_project_payload(), source, exact_urls) == ("0.4.105", "0.4.106")

payload = stable_project_payload()
payload["releases"]["0.4.106"][0]["yanked"] = True
with pytest.raises(ProjectSurfaceError, match="historical release 0.4.106 must remain retained and non-yanked"):
verify_stable_project_json(payload, source, exact_urls)
assert verify_stable_project_json(payload, source, exact_urls) == ("0.4.105", "0.4.106")


def test_prerelease_evidence_records_deferred_default_surface(
Expand Down