chore: give each package its own tsconfig, drop the root tsconfig folder - #63
Merged
Conversation
tsconfig/react.json actually typechecked everything except solid, while the solid project already lived in its package — an inconsistent split. Now the root tsconfig.json is the shared base (it also covers the root config files), tsconfig.build.json is the tsc -b solution list, and every package owns its project config. Only react and solid set a JSX flavor. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: Ivan Banov <ivanbanov@gmail.com>
Signed-off-by: Ivan Banov <ivanbanov@gmail.com>
Signed-off-by: Ivan Banov <ivanbanov@gmail.com>
Solid 2.0 renders a boolean attribute as presence/absence, so
aria-expanded={false} disappeared and aria-modal={true} rendered empty.
ARIA states are literal "true"/"false" tokens — serialize them explicitly.
Found by the solid-dialog binding in dunky-dev/ui#44.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Conflict: packages/solid/src/normalize.ts — solid extracted the shared DOM attr map into @dunky.dev/state-machine-dom, superseding this branch's inline copy; kept solid's spread form. Semantic fix folded in: packages/dom arrived on solid after this branch forked, so it gets its own tsconfig.json and a tsconfig.build.json reference — otherwise the new package would silently escape typechecking under the per-package scheme. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tsconfig/is gone. The roottsconfig.jsonis now the shared base (options + paths, plus the root config files), andtsconfig.build.jsonis thetsc -bsolution listpnpm typecheckruns.packages/{core,react,solid,native,opentui,shared/utils,shared/bindings}/tsconfig.json. Only react (react-jsx) and solid (preserve+@solidjs/web) set a JSX flavor.Why
tsconfig/react.jsonwas misleadingly named — it typechecked everything except solid, while the solid project already lived inside its package. This makes the layout consistent with the per-package vitest configs: config lives with the code it describes, and no package's settings leak into another's.No changeset: internal tooling only, nothing ships to consumers.
Stacked on #32.
🤖 Generated with Claude Code