[code-simplifier] Simplify instrumentation builder methods

[github-actions]

Code Simplification - 2026-09-03

This PR simplifies recently added builder extension methods to improve clarity and reduce unnecessary branching while preserving all functionality.

Files Simplified

• src/WitnessSharp/WitnessBuilderExtensions.cs - Eliminated redundant null-check branches in two instrumentation methods

Improvements Made

1. Reduced Complexity

   • Removed if-else blocks in WithAspNetCoreInstrumentation() and WithHttpClientInstrumentation() methods
   • The OpenTelemetry SDK methods accept nullable configure delegates, making the branching unnecessary
   • Direct parameter passing is clearer and more maintainable

2. Enhanced Clarity

   • Makes it immediately obvious that these are simple pass-throughs to the OTel SDK
   • Reduced from 17 lines to 7 lines per method (~59% reduction per method)
   • Eliminates cognitive overhead from conditional logic

3. Applied Project Standards

   • Follows the pattern: delegate directly when the underlying method supports it
   • Maintains consistency with the project's preference for explicit, straightforward code over clever conditionals

Changes Based On

Initial commit of WitnessSharp repository (commit de160c1 - "Reduce bloat in README Recipes section #44")

Testing

• ✅ All 180+ tests pass across both net8.0 and net10.0 target frameworks
• ✅ No functional changes - behavior is identical
• ✅ Configuration still works as expected with both explicit and default null configure parameters

Review Focus

Please verify:

• Functionality is preserved (all tests pass)
• Simplifications improve code quality and readability
• The change aligns with the project's preference for explicit, straightforward code

Generated by Code Simplifier · ● 209.2K · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/code-simplifier.md@1c6668b751c51af8571f01204ceffb19362e0f66

• expires on Sep 4, 2026, 2:52 PM UTC