Resolve @dynamic Retry-After for any status code in GenericRandomErrorPlugin - #1909
Open
waldekmastykarz wants to merge 2 commits into
Open
waldekmastykarz wants to merge 2 commits into
waldekmastykarz wants to merge 2 commits into
Conversation
…rPlugin Previously @dynamic was only resolved for 429 responses, so 503/529 errors sent the literal '@dynamic' value. Closes dotnet#1905 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Core registration and case-insensitive matching behavior need direct regression coverage.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Extends dynamic Retry-After handling to non-429 responses.
Changes:
- Resolves dynamic headers for any status code with case-insensitive matching.
- Adds 503 integration coverage.
| File | Description |
|---|---|
GenericRandomErrorPlugin.cs |
Broadens dynamic header handling. |
BehaviorPluginsIntegrationTests.cs |
Tests dynamic 503 response headers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Use mixed-case header name to cover case-insensitive lookup and verify RetryAfterPlugin throttles an immediate retry. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1905
GenericRandomErrorPluginonly resolved@dynamic/@dynamic=Nin theRetry-Afterheader for 429 responses, so 503/529 errors (used by presets likeopenai-throttlingandanthropic-throttling) sent the literal@dynamicvalue.Changes:
@dynamicinRetry-Afterregardless of status code and register the request withRetryAfterPluginRetry-Afterheader name case-insensitively@dynamic=7