Skip to content

[Scheduled Run] Localized resource files from OneLocBuild - #4554

Open
cheenamalhotra wants to merge 1 commit into
mainfrom
dev/automation/onelocbuild-20260819-193154
Open

[Scheduled Run] Localized resource files from OneLocBuild#4554
cheenamalhotra wants to merge 1 commit into
mainfrom
dev/automation/onelocbuild-20260819-193154

Conversation

@cheenamalhotra

Copy link
Copy Markdown
Member

Automated PR created from the OneLocBuild scheduled pipeline run.

Contains updated localized Strings.*.resx resource files.

@cheenamalhotra
cheenamalhotra requested a review from a team as a code owner August 19, 2026 19:32
Copilot AI lite review requested due to automatic review settings August 19, 2026 19:32
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Aug 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This scheduled OneLocBuild PR updates satellite resource files for multiple cultures by adding the missing VerifyEnclaveKeyBindingFailed string entry so it is present across localized Strings.*.resx files.

Changes:

  • Added VerifyEnclaveKeyBindingFailed to multiple localized .resx files.
  • Populated the new entry with the current (English) neutral-string text in each satellite resource.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
src/Microsoft.Data.SqlClient/src/Resources/Strings.zh-Hant.resx Adds VerifyEnclaveKeyBindingFailed entry to the zh-Hant satellite resources.
src/Microsoft.Data.SqlClient/src/Resources/Strings.zh-Hans.resx Adds VerifyEnclaveKeyBindingFailed entry to the zh-Hans satellite resources.
src/Microsoft.Data.SqlClient/src/Resources/Strings.tr.resx Adds VerifyEnclaveKeyBindingFailed entry to the Turkish satellite resources.
src/Microsoft.Data.SqlClient/src/Resources/Strings.ru.resx Adds VerifyEnclaveKeyBindingFailed entry to the Russian satellite resources.
src/Microsoft.Data.SqlClient/src/Resources/Strings.pt-BR.resx Adds VerifyEnclaveKeyBindingFailed entry to the pt-BR satellite resources.
src/Microsoft.Data.SqlClient/src/Resources/Strings.pl.resx Adds VerifyEnclaveKeyBindingFailed entry to the Polish satellite resources.
src/Microsoft.Data.SqlClient/src/Resources/Strings.ko.resx Adds VerifyEnclaveKeyBindingFailed entry to the Korean satellite resources.
src/Microsoft.Data.SqlClient/src/Resources/Strings.ja.resx Adds VerifyEnclaveKeyBindingFailed entry to the Japanese satellite resources.
src/Microsoft.Data.SqlClient/src/Resources/Strings.it.resx Adds VerifyEnclaveKeyBindingFailed entry to the Italian satellite resources.
src/Microsoft.Data.SqlClient/src/Resources/Strings.fr.resx Adds VerifyEnclaveKeyBindingFailed entry to the French satellite resources.
src/Microsoft.Data.SqlClient/src/Resources/Strings.es.resx Adds VerifyEnclaveKeyBindingFailed entry to the Spanish satellite resources.
src/Microsoft.Data.SqlClient/src/Resources/Strings.de.resx Adds VerifyEnclaveKeyBindingFailed entry to the German satellite resources.
src/Microsoft.Data.SqlClient/src/Resources/Strings.cs.resx Adds VerifyEnclaveKeyBindingFailed entry to the Czech satellite resources.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.zh-Hans.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.zh-Hant.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.tr.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.ru.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.pt-BR.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.it.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.fr.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.es.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.de.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.cs.resx
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.28%. Comparing base (ee6fabd) to head (3ddabea).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4554      +/-   ##
==========================================
- Coverage   65.23%   63.28%   -1.96%     
==========================================
  Files         288      283       -5     
  Lines       44587    67609   +23022     
==========================================
+ Hits        29087    42787   +13700     
- Misses      15500    24822    +9322     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 63.28% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheenamalhotra
cheenamalhotra enabled auto-merge (squash) August 20, 2026 20:24
@cheenamalhotra cheenamalhotra added Hotfix 7.0.3 PRs targeting main that should be backported to release/7.0 branch for next release. Hotfix 6.1.7 PRs targeting main that should be backported to release/6.1 branch for future hotfix labels Aug 20, 2026
@cheenamalhotra
cheenamalhotra enabled auto-merge (squash) August 20, 2026 21:12
<value>Ověření podpisu sestavy enklávy se nezdařilo. Podpis sestavy neodpovídá podpisu vypočítanému pomocí kořenového certifikátu HGS. Ověřte mapování DNS pro koncový bod. Další podrobnosti najdete na https://go.microsoft.com/fwlink/?linkid=2160553. Pokud je to správně, obraťte se na oddělení služeb zákazníkům.</value>
</data>
<data name="VerifyEnclaveKeyBindingFailed" xml:space="preserve">
<value>Enclave attestation failed because the signed enclave report did not bind to the enclave public key used to establish the session. The enclave public key must match the value committed to by the signed report - see https://go.microsoft.com/fwlink/?linkid=2160553 for more details. If correct, contact Customer Support Services.</value>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these all supposed to be English, despite being in the other languages' files?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Loc pipeline first adds the English counterparts in all resx files. The LCL files receive translations on the back-end and when they are updated, the next loc run updates these english values to translated ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hotfix 6.1.7 PRs targeting main that should be backported to release/6.1 branch for future hotfix Hotfix 7.0.3 PRs targeting main that should be backported to release/7.0 branch for next release.

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

6 participants