Updated old twigs, added html tags and style. - #66
Open
OStefan2001 wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #66 +/- ##
==========================================
Coverage 17.67% 17.67%
Complexity 250 250
==========================================
Files 55 55
Lines 1058 1058
==========================================
Hits 187 187
Misses 871 871 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
arhimede
reviewed
Aug 4, 2026
|
|
||
| $sourceIndex = indexUploadSources($uploadsDir, $ogDir); | ||
|
|
||
| if (! is_dir($ogDir) && ! mkdir($ogDir, 0775, true) && ! is_dir($ogDir)) { |
Member
There was a problem hiding this comment.
what is this shell file ?
It is supposed to be part of the codebase or is an one-time action to migrate images ?
Collaborator
Author
There was a problem hiding this comment.
before I was using article->id in path, but now it is not usefull to be part of project.
| } | ||
|
|
||
| if ($baseUrl !== '' && str_starts_with($image, $baseUrl . '/')) { | ||
| if (str_starts_with($image, '/uploads/opengraph/article/')) { |
Member
There was a problem hiding this comment.
the path should be: /opengraph/article/ and not /uploads/opengraph/article/
we have some misunderstandinngs here ..
Collaborator
Author
There was a problem hiding this comment.
I will fix this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.