Skip to content

update composer and workflows, code refactor, created docs for v5 - #39

Open
bidi47 wants to merge 3 commits into
4.0from
update-php
Open

bidi47 wants to merge 3 commits into
4.0from
update-php

Conversation

@bidi47

@bidi47 bidi47 commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

DO NOT MERGE
this PR is intended for review purposes and is a draft for the v5 release

note: PHP 8.6 is not supported yet by 3rd party dependencies

  • laminas/laminas-eventmanager (v3.15)
  • laminas/laminas-servicemanager (v4.5.1)

@bidi47

bidi47 commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

regarding the reoval of psr/http-message from composer.json
it's not used explicitly in the code, but it's installed via laminas/laminas-servicemanager

@alexmerlin alexmerlin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/*:

Comment thread composer.json Resolved
Comment thread phpstan.neon Resolved
Comment thread README.md Resolved
@arhimede

arhimede commented Nov 2, 2026

Copy link
Copy Markdown
Member

laminas/laminas-servicemanager

ok, let's remove it from compsoser.json

@alexmerlin

Copy link
Copy Markdown
Member

Also, let's ignore_php_platform_requirements for PHP 8.6 so we have less CI failures.

See https://github.com/dotkernel/dot-cli/blob/3.0/.laminas-ci.json#L2 as an example.

Signed-off-by: bidi <bidi@apidemia.com>
@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@bidi47
bidi47 requested a review from alexmerlin November 2, 2026 11:14
Signed-off-by: bidi <bidi@apidemia.com>
@bidi47

bidi47 commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

if the most recent edits are ok, we need to create branch v5 (default. protected) and merge these changes into it (and cancel the current PR)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants