Repository navigation
Fix status api 404 on empty listings - #124
Merged
Merged
Conversation
… lists not 404 if there are no incidents or events
gabor-lbl
reviewed
Aug 25, 2026
| ) | ||
| if not incidents: | ||
| raise HTTPException(status_code=404, detail="No incidents found") | ||
| return incidents |
Contributor
There was a problem hiding this comment.
Or just add a return to the previous line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #109
This PR makes the status api for incidents and events consistent with the other listing api calls in IRI by returning an empty array rather than throwing a 404 when there are no incidents or events to return.