test cli without versions - #337
Closed
denis-yuen wants to merge 3 commits into
Closed
denis-yuen wants to merge 3 commits into
denis-yuen wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #337 +/- ##
=============================================
- Coverage 23.76% 23.75% -0.02%
+ Complexity 398 396 -2
=============================================
Files 48 48
Lines 6046 6046
Branches 800 800
=============================================
- Hits 1437 1436 -1
Misses 4420 4420
- Partials 189 190 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
denis-yuen
marked this pull request as ready for review
September 2, 2026 19:17
Member
Author
|
Not needed after dockstore/dockstore#6354 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test CLI with newer version of webservice that does not return version information in described endpoints.
A spot-check revealed no real side-effects. The CLI is significantly behind the web service tests and the UI in complexity and thoroughness, so this is not too surprising.
Review Instructions
Tests pass. Can do a spot-check as well.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5761
See also #337
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
./mvnw clean install