Repository navigation
Don't confirm etcd CRITICAL from an HTML mention - #46
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Port 2379 is in the default scan set. GET /v2/keys or /v3/cluster/member/list returning 200 with a substring like member, "action", or "node" was enough to pin unauthenticated etcd access. SPA catch-alls and JS bundles contain those tokens; fusion then treats source=probe findings as un-droppable. Require the JSON v2 keys document (node with key/dir/value) or v3 MemberList (members array of member objects). Co-authored-by: dmitryflynn <dmitryflynn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port 2379 is in the default scan set, so every Active Probes / Full scan runs
check_etcd_noauth.Bug: A 200 response whose body merely contained the substring
member(v3 path) or"action"/"node"(v2 path) confirmed CRITICAL unauthenticated etcd key-value access. Fusion treatssource=probe+ high reliability as pinned/un-droppable.Trigger: Scan a host with 2379 open that is actually a docker-mapped frontend or SPA catch-all. GET
/v2/keysor/v3/cluster/member/listreturns the same HTML/JS bundle. Those bundles routinely contain"action","node", or the word "member" (“Already a member?”, Redux actions,node_modules). The scan reports fusion-pinned CRITICAL etcd exposure.Fix: Parse JSON and require a real etcd payload — v2 keys document (
nodeobject withkey/dir/value) or v3 MemberList (membersarray of member objects withpeerURLs/clientURLs/ID). HTML, health JSON, and generic{"action":…}objects no longer confirm.Validation:
python3 -m pytest test_probers.py -q— 46 passed, including new HTML/JS negative cases and v2/v3 JSON positive cases.