Repository navigation
Don't confirm MongoDB CRITICAL from the isMaster handshake - #38
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
hello/isMaster is always allowed without credentials, including on clusters with --auth enabled. Require an unauthenticated listDatabases reply (BSON databases array) before reporting unauthenticated access. Co-authored-by: dmitryflynn <dmitryflynn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
check_mongodb_noauthtreated a successfulisMaster/hellowire-protocol reply as confirmed CRITICAL unauthenticated MongoDB access.MongoDB always answers
hello/isMasterwithout credentials, including when--authis enabled. Fusion maps everyservice_probe_resultfinding tosource=probe+ high reliability, and the gate pins those as un-droppable. A false CRITICAL therefore lands in the report, HackerOne export, and executive summary.Redis already fail-closes on
NOAUTH. MongoDB did not distinguish handshake from data access.Trigger:
--probe/--full(or any GUI scan with probes) against a host with 27017 open:ismaster/maxBsonObjectSize/localTimeMongoDB — Unauthenticated Access(CRITICAL) even thoughlistDatabaseswould returnUnauthorizedRoot cause
Identity was used as authorization.
isMasterOP_QUERY succeeding means “this is MongoDB”, not “unauthenticated data access”.Fix
isMasterOP_QUERY as the identity check.listDatabases(OP_MSG, required on MongoDB 6+) returns the BSONdatabasesarray.Unauthorized/requires authentication, and do not substring-matchdatabases(the auth-error errmsg containslistDatabases).Validation
python3 -m pytest test_probers.py test_hardening.py -q— 64 passed.