Repository navigation
Don't let a failed CVE probe confirm the banner match - #37
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
A verifier miss was still emitted as a high-reliability signal, so fusion treated "we tried a probe" as corroboration and auto-confirmed the NVD version hit. The CVE-2021-40438 builtin also treated a generic nginx 502 as proof of Apache mod_proxy SSRF. Only confirmed verifier results enter the gate now, and the builtin plans require distinctive httpd errors instead of "Bad Gateway". Co-authored-by: dmitryflynn <dmitryflynn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
An AI/full scan of Apache (or any host whose banner correlated a high-CVSS CVE with a builtin verifier plan) could persist that CVE as fusion-confirmed even when the active probe failed — and a generic nginx
502 Bad Gatewaywas enough to pin CVE-2021-40438 (mod_proxy SSRF, CVSS 9.1) as un-droppable.Trigger: scan with
--ai/--fulland an AI completer againstApache/2.4.41behind a reverse proxy. NVD returns CVE-2021-40438. The verifier sendsGET /?unix:///var/run/example.socket|http://127.0.0.1:80/. The front proxy returns 404 or a stock nginx 502. Fusion auto-confirmed the banner hit.Root cause
run_verifieralways emitted areliability=highsignal, including on miss. That broke the gate's version-only discard (nvd+ failedverifier= 2 sources and a high-reliability sensor → confirmed). Separately, the CVE-2021-40438 builtin treated body substrings"Bad Gateway"/"proxy"as proof.Fix
AH00957,mod_proxy, …) instead of a generic 502.Validation
python3 -m pytest test_fusion.py test_fusion_engine_bridge.py test_verifier_sanitize.py test_gate_version_cap.py test_fusion_adjudicator.py -q— 76 passed.python3 -m pytest test_*.py -q— 1758 passed, 5 skipped.python3 -m bandit -r src/fusion/gate.py src/fusion/engine_bridge.py src/verifier src/engine.py --severity-level high— no high issues.