Skip to content

feat(datetime): publicly import std.datetime.stopwatch in std.datetime - #11095

Open
schveiguy wants to merge 1 commit into
dlang:masterfrom
schveiguy:import-datetime-stopwatch
Open

feat(datetime): publicly import std.datetime.stopwatch in std.datetime#11095
schveiguy wants to merge 1 commit into
dlang:masterfrom
schveiguy:import-datetime-stopwatch

Conversation

@schveiguy

@schveiguy schveiguy commented Sep 7, 2026

Copy link
Copy Markdown
Member

Note, the removal of the offending std.datetime.benchmark function occurred June 2021, and TickDuration itself is about to be removed. There is no reason not to import this module implicitly like all other models.

Rationale

The reason for the lack of public import is long gone. Let's see if anything breaks.

Pre-review checklist

  • I have performed a self-review of my code.
  • If my PR fixes a bug or introduces a new feature, I have added thorough tests.
  • If my changes are non-trivial and do not concern a reported issue, I have added a changelog entry.

LLM/AI disclosure

I wrote this myself! I deserve three gold stars.

@schveiguy
schveiguy requested a review from jmdavis as a code owner September 7, 2026 20:26
@schveiguy

Copy link
Copy Markdown
Member Author

This should have a changelog, don't merge yet.

@Herringway

Copy link
Copy Markdown
Contributor

⭐⭐⭐

@0xEAB

0xEAB commented Sep 7, 2026

Copy link
Copy Markdown
Member

I wrote this myself! I deserve three gold stars.

Here you are: 🏅🏅🏅

@schveiguy
schveiguy force-pushed the import-datetime-stopwatch branch from d9b02fd to b6c6484 Compare September 7, 2026 21:00
@schveiguy

Copy link
Copy Markdown
Member Author

OK, changelog added.

@thewilsonator

Copy link
Copy Markdown
Contributor

Style CI fails

Check for trailing whitespace
grep -nr '[[:blank:]]$' $(find etc std -name '*.d'); test $? -eq 1
std/utf.d:3740: *      Otherwise, `r` is converted to its corresponding string type.

@0xEAB

0xEAB commented Sep 7, 2026

Copy link
Copy Markdown
Member

Rebasing should fix that. (#11096)

package.

Note, the removal of the offending benchmark function occurred June
2021, and TickDuration itself is about to be removed. There is no reason
not to import this module implicitly like all other models.
@0xEAB
0xEAB force-pushed the import-datetime-stopwatch branch from b6c6484 to b96b4ac Compare September 11, 2026 17:47
@0xEAB

0xEAB commented Sep 11, 2026

Copy link
Copy Markdown
Member

Rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants