feat(datetime): publicly import std.datetime.stopwatch in std.datetime - #11095
Open
schveiguy wants to merge 1 commit into
Open
feat(datetime): publicly import std.datetime.stopwatch in std.datetime#11095schveiguy wants to merge 1 commit into
schveiguy wants to merge 1 commit into
Conversation
Member
Author
|
This should have a changelog, don't merge yet. |
Contributor
|
⭐⭐⭐ |
Member
Here you are: 🏅🏅🏅 |
schveiguy
force-pushed
the
import-datetime-stopwatch
branch
from
September 7, 2026 21:00
d9b02fd to
b6c6484
Compare
Member
Author
|
OK, changelog added. |
0xEAB
approved these changes
Sep 7, 2026
Contributor
|
Style CI fails |
Member
|
Rebasing should fix that. (#11096) |
package. Note, the removal of the offending benchmark function occurred June 2021, and TickDuration itself is about to be removed. There is no reason not to import this module implicitly like all other models.
0xEAB
force-pushed
the
import-datetime-stopwatch
branch
from
September 11, 2026 17:47
b6c6484 to
b96b4ac
Compare
Member
|
Rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, the removal of the offending
std.datetime.benchmarkfunction occurred June 2021, andTickDurationitself is about to be removed. There is no reason not to import this module implicitly like all other models.Rationale
The reason for the lack of public import is long gone. Let's see if anything breaks.
Pre-review checklist
LLM/AI disclosure
I wrote this myself! I deserve three gold stars.