ARB + ICU json frameworks | android + iOS locales output directories - #157
Merged
Conversation
…ng file structure.
…onfigure mobile outputs to go to separate root folders.
…he framework to follow other json formats
laurakoye
approved these changes
Aug 28, 2026
laurakoye
left a comment
Contributor
There was a problem hiding this comment.
there is one regional bug for arb, but other than that it's good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
arbframework for thejsonformaticuframework for thejsonformat (was previously just formatjson_icu, which still works but logs a warning and is marked deprecated)androidLocalesto matchiosLocalesandroidLocalesOutDirandiosLocalesOutDirfor outputting android/iOS files to different root directoriesContext
See ditto-app PR for corresponding backend and documentation changes
Test Plan
Testing successfully completed in
localvia:allvariantsandroid,ios-strings,ios-stringsdict,json(w/ frameworkarb) formatsiosLocalesandandroidLocalesspecified for all of your variantsoutDir,iosLocalesOutDirandandroidLocalesOutDirall specified to separate web/iOS/android outputspull(oryarn syncif running from this project)outDir, iOS files in the appropriate structure in youriosLocalesOurDirand android files in the appropriate structure inandroidLocalesOutDir.Sample config