Skip to content

ARB + ICU json frameworks | android + iOS locales output directories - #157

Merged
joustrich merged 6 commits into
masterfrom
joustrich/pull-output-updates
Sep 1, 2026
Merged

ARB + ICU json frameworks | android + iOS locales output directories#157
joustrich merged 6 commits into
masterfrom
joustrich/pull-output-updates

Conversation

@joustrich

Copy link
Copy Markdown
Contributor

Overview

  • New arb framework for the json format
  • New icu framework for the json format (was previously just format json_icu, which still works but logs a warning and is marked deprecated)
  • New androidLocales to match iosLocales
  • New androidLocalesOutDir and iosLocalesOutDir for outputting android/iOS files to different root directories

Context

See ditto-app PR for corresponding backend and documentation changes

Test Plan

Testing successfully completed in local via:

  • Make sure you have a few variants set up with corresponding locales
  • Make sure your config has the following (see my example config below)
    • all variants
    • android, ios-strings, ios-stringsdict, json (w/ framework arb) formats
    • iosLocales and androidLocales specified for all of your variants
    • outDir, iosLocalesOutDir and androidLocalesOutDir all specified to separate web/iOS/android outputs
  • Once you have the config set up against your projects, run pull (or yarn sync if running from this project)
  • You should see your ARB json files in the outDir, iOS files in the appropriate structure in your iosLocalesOurDir and android files in the appropriate structure in androidLocalesOutDir.

Sample config

projects:
  - id: "jao-test"
variants:
  - id: "base"
  - id: "spanish"
  - id: "french"
  - id: "german"
outputs:
  - format: android
  - format: ios-strings
  - format: ios-stringsdict
  - format: json
    framework: arb
outDir: "ditto/json"
iosLocales:
  - base: en
  - spanish: es
  - french: fr
  - german: de
iosLocalesOutDir: "ditto/ios"
androidLocales:
  - base: en
  - spanish: es
  - french: fr
  - german: de
androidLocalesOutDir: "ditto/android"

@laurakoye laurakoye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is one regional bug for arb, but other than that it's good

Comment thread lib/src/formatters/android.ts Outdated
@joustrich
joustrich merged commit aa94e42 into master Sep 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants