Repository navigation
perf(compiler): retain numeric loops and virtual arguments - #99
Merged
Merged
Conversation
- Admit certified imul and clz32 calls to existing safe-integer regions, retaining entry guards and iteration fallback. - Cover mutable and locked builtins, zero-trip identity, numeric boundaries, coercion, abrupt completion and GC polling. - Serial compute: 921.0 to 191.7 ms over seven matched pairs; broader JavaScript absolute timings remain inconclusive. - Validate 60 focused unit tests, 34 native checks, type-check and lint.
- Admit present writable Array elements and private prepared Number keys in fixed storage loops. - Check independent indices before committing a sole store and preserve deletion barriers and completed-iteration polling. - Cover fallback semantics, aliases, descriptors and GC stress; retain key-once Test262 regressions. - Validate 64 focused unit checks, both UBSan fixture variants, three Test262 paths, type-check and lint. am3 improves 1862 to 1141 ms over seven pairs, indicative; the V8 comparison remains inconclusive after concurrent host work.
- Keep scaled DataView byte-window proofs when selecting checked terminal stores. - Verify per-access bounds for newly admitted non-affine stores and stale induction inputs; retain rejection of observable effects. - Validate 148 focused planner checks, eight native DataView checks, type-check and lint.
- Retain and root complete incoming slices for guarded unmapped element reads. - Keep object fallback, mapped parameters and activation-sensitive transforms safe. - Cover codec retention, nested calls, inherited indices and heap identity under UBSan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numeric loops repeatedly box integer Math results and rediscover Array storage. Dynamic arguments reads also create property tables under mutable primordials. Retain guarded loop state and read eligible unmapped arguments directly from a rooted incoming slice.
Local ARM64 closed-world production measurements on AC power, seven interleaved pairs with matching checksums:
V8 v7, three interleaved pairs after warmup per comparison. Higher scores are better; every internal check and all eight sub-scores pass. Each sample has ready/AC environment probes before and after it.
Dense Array comparison:
824d76843to630e49060, total +4.6%, Crypto +37.3%, NavierStokes +0.1%. Incoming comparison:630e49060toc09015518, total +2.6%, EarleyBoyer +21.9% with paired gains 22.16%, 21.62%, 21.47%; NavierStokes -1.6%. Other non-target changes in that run range from -1.8% to +2.0%.These are narrow measured wins. Broader JavaScript v1/v2 wall time remains inconclusive; Node-normalized v1 ratios flagged regressions as the reference varied. No broad portfolio improvement claim.
Focused local correctness, native backend parity, GC stress, UBSan, selected key-conversion Test262 checks, type-check and lint pass. The incoming slice adds 299 focused unit checks and three UBSan native cases; the full eval-based arguments selection reached its 300-second cap without completed fixtures. Current-head canonical CI is pending; all canonical lanes passed on
630e49060.Retained local evidence:
.cache/bench-codex-20261108/, including source identities, raw samples and the source for the existing Project Visualize artifact.