filesystem: fixed failing put_file call with the XBee Wi-SUN - #324
Open
kurte261 wants to merge 1 commit into
Open
filesystem: fixed failing put_file call with the XBee Wi-SUN#324kurte261 wants to merge 1 commit into
kurte261 wants to merge 1 commit into
Conversation
Removed a check in WriteFileCmdRequest that generated an error if the write block size was greater than 248 bytes long. This is a problem on platforms such as XBee Wi-SUN which have a NP value higher than this limit. In the case of XBee Wi-SUN the higher level filesystem would calculate a much bigger block size which would fail in the lower level filesystem because of this check.
kurte261
force-pushed
the
kurte/remove-too-aggressive-file-block-size-check
branch
from
August 31, 2026 18:42
036da4b to
d86c0ac
Compare
Author
|
There is an issue with the change. |
Author
|
After further review, I think this fix is the right one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed a check in WriteFileCmdRequest that generated an error if the write block size was greater than 248 bytes long. This is a problem on platforms such as XBee Wi-SUN which have a NP value higher than this limit. In the case of XBee Wi-SUN the higher level filesystem would calculate a much bigger block size which would fail in the lower level filesystem because of this check.