Skip to content

refactor(scripts): retire legacy Notion fetch and translate pipelines (#192) - #212

Merged
luandro merged 2 commits into
mainfrom
refactor/192-retire-legacy-notion-fetch
Sep 18, 2026
Merged

luandro merged 2 commits into
mainfrom
refactor/192-retire-legacy-notion-fetch

Conversation

@luandro

@luandro luandro commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Phase 4 of Notion fetch retirement and architecture simplification (resolving #192).

Architecture Progression

  • Phase 1: Generated content moved off main and onto the dedicated content branch.
  • Phase 2: PR previews switched to building from the content branch without running notion:fetch.
  • Phase 3: Theme-chrome translation extracted into standalone scripts/translate-theme/ (refactor(i18n): extract theme-chrome translation into standalone module (#192) #210).
  • External migration: Canonical Notion fetch, content materialization, and page translation now run in ../comapeo-content-pipeline/ pushing to the content branch.

Changes

  1. Workflows Removed (Approved Maintenance Migration):

    • Approved maintainer cleanup: .github/workflows/translate-docs.yml (legacy translation workflow replaced by external pipeline)
    • Approved maintainer cleanup: .github/workflows/clean-content.yml (content lifecycle now pipeline-owned)
  2. Legacy Scripts & Tests Deleted:

    • scripts/notion-fetch/, scripts/notion-fetch-all/, scripts/notion-fetch-one/, scripts/notion-api/, scripts/archived-notion-fetch/
    • scripts/notion-translate/, scripts/notion-placeholders/, scripts/notion-test-pages/, scripts/eval/
    • scripts/notionClient.ts, scripts/fetchNotionData.ts, scripts/notionPageUtils.ts, scripts/perfTelemetry.ts, scripts/push-new-translation-to-notion.ts, scripts/run-single-page-translation.ts, scripts/migrate-image-cache.ts
    • scripts/shared/errors.ts and scripts/test-utils/ (retaining scripts/test-utils.ts and scripts/shared/localeImagePlaceholders.ts)
    • NOTION_FETCH_ARCHITECTURE.md and scripts/notion-workflow-guide.md
  3. Kept with Verified Callers:

  4. Dependencies & Config:

    • Dropped legacy package.json scripts (notion:fetch*, notion:translate*, etc.)
    • Removed unused packages: notion-to-md, axios, imagemin*, yaml, zod
    • Updated lefthook.yml (removed notion-fetch-tests hook)
    • Cleaned up tsconfig.json, .env.example (retained DATA_SOURCE_ID), eslint.config.mjs, README.md, CONTRIBUTING.md, AGENTS.md
    • Updated scripts/test-scaffold/templates.ts to mock full retained Notion client surface (databases, dataSources, blocks, pages)
    • Updated scripts/migration/discoverDataSource.ts with read-only verification command

Closes #192
Closes #113
Closes #114
Closes #139
Closes #174
Closes #175

RetriggerConfidence Score: 5/5

PR appears safe to merge; no outstanding blocking or non-blocking code issue remains.

Summary

Retires repository-local Notion content fetching and page-translation pipelines after those responsibilities moved to the external content-pipeline repository.

  • Deletes legacy fetch, translation, placeholder, evaluation, and supporting test code.
  • Removes superseded translation and content-cleanup workflows.
  • Removes obsolete package scripts and dependencies.
  • Updates configuration and operational documentation for the external pipeline.
  • Retains Notion status/version/template utilities and standalone theme-chrome translation.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  N[Notion] --> P[comapeo-content-pipeline]
  P -->|generated docs, i18n, images| C[content branch]
  C --> B[comapeo-docs builds]
  B --> D[Preview, staging, production]
  T[Retained theme translation] --> B
  S[Retained Notion status/version utilities] --> N
Loading

Reviews (11) · Last reviewed commit: "docs: update context documentation to re..."

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@luandro

luandro commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

@greptile review

@luandro

luandro commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

@greptile-apps review

@github-actions

github-actions Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment

Your documentation preview is ready!

Preview URL: https://pr-212.comapeo-docs-82j.pages.dev

📦 Content: from content branch (same source as staging/production)

This preview will update automatically when you push new commits to this PR.


Built with commit 2297626

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c38a25f23e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .env.example
Comment thread package.json
Comment thread package.json
Comment thread .env.example
Comment thread scripts/test-scaffold/templates.ts
@luandro
luandro force-pushed the refactor/192-retire-legacy-notion-fetch branch from c38a25f to 626e104 Compare September 12, 2026 10:55
@luandro

luandro commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

@greptile-apps review

@luandro
luandro force-pushed the refactor/192-retire-legacy-notion-fetch branch from 626e104 to e895745 Compare September 12, 2026 10:59
@luandro

luandro commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

@greptile-apps review

@luandro
luandro force-pushed the refactor/192-retire-legacy-notion-fetch branch from e895745 to c5c2d43 Compare September 12, 2026 11:03
@luandro

luandro commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

@greptile-apps review

@luandro
luandro force-pushed the refactor/192-retire-legacy-notion-fetch branch from c5c2d43 to 8e87c77 Compare September 12, 2026 11:09
@luandro

luandro commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

@greptile-apps review

Comment thread scripts/migration/discoverDataSource.ts Outdated
@luandro
luandro force-pushed the refactor/192-retire-legacy-notion-fetch branch from 8e87c77 to 0c127f8 Compare September 17, 2026 13:15
@luandro

luandro commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

@greptile-apps review

1 similar comment
@luandro

luandro commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

@greptile-apps review

@luandro

luandro commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

@greptile review

Comment thread context/workflows/translation-process.md Outdated
@luandro
luandro force-pushed the refactor/192-retire-legacy-notion-fetch branch from 40a320b to b11b3c4 Compare September 18, 2026 20:32
@luandro

luandro commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@greptile-apps review

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown

Comments Outside Diff

These findings sit on lines the diff does not cover, so they could not be posted inline. Each one leaves this list once its file changes.

  • P2 CI Changes Lack Approval .github/workflows/clean-content.yml:1 ▶

    This PR deletes the content-cleanup workflow and the translation workflow, but repository guidance says not to modify CI without approval. No approval is documented in the supplied PR context. This repository requirement must be satisfied before merging; the same concern applies to .github/workflows/translate-docs.yml.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@luandro
luandro force-pushed the refactor/192-retire-legacy-notion-fetch branch from b11b3c4 to 2297626 Compare September 18, 2026 20:49
@luandro

luandro commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@greptile-apps review

@luandro
luandro merged commit 6256bca into main Sep 18, 2026
4 checks passed
@luandro
luandro deleted the refactor/192-retire-legacy-notion-fetch branch September 18, 2026 21:19
@github-actions

Copy link
Copy Markdown
Contributor

🧹 Preview Deployment Cleanup

The preview deployment for this PR has been cleaned up.

Preview URL was: https://pr-212.comapeo-docs.pages.dev


Note: Cloudflare Pages deployments follow automatic retention policies. Old previews are cleaned up automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant