Repository navigation
refactor(scripts): retire legacy Notion fetch and translate pipelines (#192) - #212
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
@greptile review |
|
@greptile-apps review |
🚀 Preview DeploymentYour documentation preview is ready! Preview URL: https://pr-212.comapeo-docs-82j.pages.dev 📦 Content: from This preview will update automatically when you push new commits to this PR. Built with commit 2297626 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c38a25f23e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c38a25f to
626e104
Compare
|
@greptile-apps review |
626e104 to
e895745
Compare
|
@greptile-apps review |
e895745 to
c5c2d43
Compare
|
@greptile-apps review |
c5c2d43 to
8e87c77
Compare
|
@greptile-apps review |
8e87c77 to
0c127f8
Compare
|
@greptile-apps review |
1 similar comment
|
@greptile-apps review |
|
@greptile review |
40a320b to
b11b3c4
Compare
|
@greptile-apps review |
Comments Outside DiffThese findings sit on lines the diff does not cover, so they could not be posted inline. Each one leaves this list once its file changes.
|
b11b3c4 to
2297626
Compare
|
@greptile-apps review |
🧹 Preview Deployment CleanupThe preview deployment for this PR has been cleaned up. Preview URL was: Note: Cloudflare Pages deployments follow automatic retention policies. Old previews are cleaned up automatically. |
Overview
Phase 4 of Notion fetch retirement and architecture simplification (resolving #192).
Architecture Progression
mainand onto the dedicatedcontentbranch.contentbranch without runningnotion:fetch.scripts/translate-theme/(refactor(i18n): extract theme-chrome translation into standalone module (#192) #210).../comapeo-content-pipeline/pushing to thecontentbranch.Changes
Workflows Removed (Approved Maintenance Migration):
.github/workflows/translate-docs.yml(legacy translation workflow replaced by external pipeline).github/workflows/clean-content.yml(content lifecycle now pipeline-owned)Legacy Scripts & Tests Deleted:
scripts/notion-fetch/,scripts/notion-fetch-all/,scripts/notion-fetch-one/,scripts/notion-api/,scripts/archived-notion-fetch/scripts/notion-translate/,scripts/notion-placeholders/,scripts/notion-test-pages/,scripts/eval/scripts/notionClient.ts,scripts/fetchNotionData.ts,scripts/notionPageUtils.ts,scripts/perfTelemetry.ts,scripts/push-new-translation-to-notion.ts,scripts/run-single-page-translation.ts,scripts/migrate-image-cache.tsscripts/shared/errors.tsandscripts/test-utils/(retainingscripts/test-utils.tsandscripts/shared/localeImagePlaceholders.ts)NOTION_FETCH_ARCHITECTURE.mdandscripts/notion-workflow-guide.mdKept with Verified Callers:
scripts/notion-status/,scripts/notion-version/,scripts/notion-create-template/(called by deploy/release workflows)scripts/translate-theme/(standalone theme translation module from PR refactor(i18n): extract theme-chrome translation into standalone module (#192) #210)scripts/remark-fix-image-paths.tsandscripts/shared/localeImagePlaceholders.ts(used indocusaurus.config.tsbuild)Dependencies & Config:
package.jsonscripts (notion:fetch*,notion:translate*, etc.)notion-to-md,axios,imagemin*,yaml,zodlefthook.yml(removednotion-fetch-testshook)tsconfig.json,.env.example(retainedDATA_SOURCE_ID),eslint.config.mjs,README.md,CONTRIBUTING.md,AGENTS.mdscripts/test-scaffold/templates.tsto mock full retained Notion client surface (databases,dataSources,blocks,pages)scripts/migration/discoverDataSource.tswith read-only verification commandCloses #192
Closes #113
Closes #114
Closes #139
Closes #174
Closes #175
PR appears safe to merge; no outstanding blocking or non-blocking code issue remains.
Summary
Retires repository-local Notion content fetching and page-translation pipelines after those responsibilities moved to the external content-pipeline repository.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR N[Notion] --> P[comapeo-content-pipeline] P -->|generated docs, i18n, images| C[content branch] C --> B[comapeo-docs builds] B --> D[Preview, staging, production] T[Retained theme translation] --> B S[Retained Notion status/version utilities] --> NReviews (11) · Last reviewed commit: "docs: update context documentation to re..."