Skip to content

Format with palantir-java-format, checked by Spotless - #11

Merged
diegourban merged 3 commits into
masterfrom
spotless
Nov 6, 2026
Merged

diegourban merged 3 commits into
masterfrom
spotless

Conversation

@diegourban

Copy link
Copy Markdown
Owner

Clean-code PR A of 4 (formatting → final → Javadoc → approved findings).

Commits

  1. f490a4f Reformat all Java sources (115 files). This changes only whitespace, line and comment wrapping, and import order (palantir puts static imports first), plus one unused import removed from StringUtilsTest.
    Verified mechanically: with comments removed, whitespace collapsed and imports compared as sets, every file is identical to before.
  2. 2934395 Spotless in the build: spotless-maven-plugin 3.11.0 with palantir-java-format 2.103.0 and removeUnusedImports.
    • ./mvnw verify now fails on unformatted code; ./mvnw spotless:apply fixes it.
    • Adds .git-blame-ignore-revs listing the reformat commit, so GitHub's blame view skips it. Locally: git config blame.ignoreRevsFile .git-blame-ignore-revs.
    • The README build section mentions spotless:apply.

⚠️ Merge with a merge commit (not squash or rebase). .git-blame-ignore-revs refers to f490a4f by hash, and squashing would change that hash.

Test plan

  • ./mvnw verify: format check passes, 574 tests, coverage floors met
  • CI, Codacy, Codecov green

🤖 Generated with Claude Code

diegourban and others added 2 commits November 6, 2026 16:30
Whitespace, line wrapping, comment wrapping and import order only, plus
one unused import removed (StringUtilsTest). Verified: with comments
removed, whitespace collapsed and imports compared as sets, every file
is identical to before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
./mvnw verify now fails on unformatted sources; ./mvnw spotless:apply
fixes them. The bulk reformat commit is listed in .git-blame-ignore-revs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov-commenter

codecov-commenter commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.65%. Comparing base (3d2320e) to head (4951c41).

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
+ Coverage     99.48%   99.65%   +0.16%     
- Complexity      278      279       +1     
============================================
  Files            24       24              
  Lines           584      576       -8     
  Branches         94       94              
============================================
- Hits            581      574       -7     
+ Partials          3        2       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

✅ No blocking issues noticed

No blocking findings were identified. The main validation gaps are the absence of automated coverage for formatting enforcement, the apply command, and the Git blame configuration.

About this PR

  • Consider adding automated checks covering formatting enforcement, the formatting apply workflow, and recognition of the blame-ignore configuration.

Test suggestions

  • Maven verification detects formatting violations.
  • Spotless apply formats sources and removes unused imports.
  • The documented blame-ignore revision is recognized by Git tooling.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Maven verification detects formatting violations.
2. Spotless apply formats sources and removes unused imports.
3. The documented blame-ignore revision is recognized by Git tooling.

Make this review better

TIP Add a ticket key to the branch or title so the reviewer can check the PR against it. Or tell us which ticket tracker you use here.
TIP Add Codacy review.md instructions or an AGENTS.md so the reviewer knows your conventions.

TIP How was this review? Give us feedback

# Conflicts:
#	src/main/java/io/github/diegourban/algorithms/datastructure/vector/Vector.java
#	src/test/java/io/github/diegourban/algorithms/datastructure/linkedlist/LinkedListTest.java
#	src/test/java/io/github/diegourban/algorithms/datastructure/set/SetTest.java
#	src/test/java/io/github/diegourban/algorithms/datastructure/vector/VectorTest.java
@diegourban
diegourban merged commit ec46c94 into master Nov 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants