fix: unbreak the release step - #1770
Merged
Merged
Conversation
The release step runs `npm version` in each workspace, which reifies the whole tree. The root typescript@~5.5.4 conflicts with react-scripts@5's peerOptional typescript@^3.2.1 || ^4, so npm fails with ERESOLVE. Yarn only warns about it, so build, test and lint were unaffected. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Contributor
|
🚀 Deployed on https://pr-1770--dhis2-ui.netlify.app |
KaiVandivier
approved these changes
Sep 25, 2026
dhis2-bot
added a commit
that referenced
this pull request
Sep 25, 2026
# [10.18.0](v10.17.0...v10.18.0) (2026-09-25) ### Bug Fixes * resolve the typescript peer conflict that breaks releases ([#1770](#1770)) ([9a0cd9d](9a0cd9d)) * **notification-icon:** align badge text color with global shell ([e73cd57](e73cd57)) * **notification-icon:** change background color to red500 for improved contrast ([660784a](660784a)) * **notification-icon:** enhance accessibility ([553b61d](553b61d)) * **notification-icon:** update box-shadow color to match the header bar background ([86ed313](86ed313)) ### Features * support writing components in TypeScript, with a placeholder OuTree ([#1764](#1764)) ([47ac8f3](47ac8f3)) * **header-bar:** add expandable notification dot indicator ([ffc9ac5](ffc9ac5)) * **select:** add menuMinWidth and menuMaxWidth to SimpleSingleSelect ([2967f90](2967f90))
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release job has been failing since #1764 (run), so 10.18.0 was never published.
@semantic-release/npmrunsnpm versionin each workspace, which makes npm reify the whole tree. #1764 addedtypescript@~5.5.4to the root, which conflicts withreact-scripts@5'speerOptional typescript@"^3.2.1 || ^4", and npm fails withERESOLVE. Yarn only warns about this, which is why build, test and lint still passed.This adds
"typescript": "$typescript"to the root npmoverrides, next to the existingreactones. Yarn 1 ignoresoverrides, soyarn.lockand local development are unchanged.Verified locally:
npm version 10.18.0 --no-git-tag-version --allow-same-versionincollections/formsfails with the CI error on master and succeeds with this change.🤖 Generated with Claude Code