Process MSVC logger events on the primary node - #151
Merged
Conversation
The distributed forwarding logger is not created for single-node MSBuild 18 builds. Run the same event parser in the central logger so unused library diagnostics still work with /m:1. Correlate parser state by node and project context so concurrent builds of the same project remain isolated even when task IDs differ between events. Copilot-Session: 1a0d74b8-3e5c-4b54-ae88-080aa7d2a62e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle the central node's
Unused libraries:output directly when no secondary node exists. This preservesReferenceTrimmerUnusedMSVCLibraries.json.loggeneration for/m:1and covers/m:Nbuilds that execute link tasks on the central node.The change also tightens context correlation so concurrent builds for the same project path do not cross-contaminate each other, while still falling back safely when MSBuild only provides partial context.
Why this is safe
Testing
31820717422at2fefc29ea7b133fa1323aa56705c1a5636fb7a7bForwardingLogger_IsolatesConcurrentBuildContextsForSameProject,ForwardingLogger_FallsBackToProjectPathForPartialBuildContexts,CentralLogger_ProcessesUnusedLibEventsFromPrimaryNode,UnusedWinSdkImportLibrary,UnusedCppLibrary,UnusedCppDelayLoadLibrary