Skip to content

test(sops): make registerSOPSSource idempotent in e2e tests - #1186

Closed
skevetter wants to merge 7 commits into
feat/sops-secret-sourcesfrom
jules-6671626066254004490-daead8b6
Closed

test(sops): make registerSOPSSource idempotent in e2e tests#1186
skevetter wants to merge 7 commits into
feat/sops-secret-sourcesfrom
jules-6671626066254004490-daead8b6

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Makes registerSOPSSource idempotent in e2e/tests/up/sops.go by attempting to remove any existing secret source prior to adding a new one, ensuring clean test state setup across test retries and sequential runs.


PR created automatically by Jules for task 6671626066254004490 started by @skevetter

Preemptively remove any existing secret source before invoking
'secret source add' in registerSOPSSource to prevent duplicate
source registration errors across e2e test runs and retries.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 0ff0f6a6-f234-4543-be5f-fbe640f5fb16

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@mergify

mergify Bot commented Sep 4, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Preemptively remove any existing secret source before invoking
'secret source add' in registerSOPSSource to prevent duplicate
source registration errors across e2e test runs and retries.
Preemptively remove any existing secret source before invoking
'secret source add' in registerSOPSSource to prevent duplicate
source registration errors across e2e test runs and retries.
Preemptively remove any existing secret source before invoking
'secret source add' in registerSOPSSource to prevent duplicate
source registration errors across e2e test runs and retries. Use
sourceSubCmd constant to satisfy goconst lint rule.
Preemptively remove any existing secret source before invoking
'secret source add' in registerSOPSSource to prevent duplicate
source registration errors across e2e test runs and retries. Use
sourceSubCmd constant to satisfy goconst lint rule and strip leading
slashes in repository relative path cleaner.
Preemptively remove any existing secret source before invoking
'secret source add' in registerSOPSSource to prevent duplicate
source registration errors across e2e test runs and retries. Use
sourceSubCmd constant to satisfy goconst lint rule, strip leading
slashes in repository relative path cleaner, and clean up resolved
workspace client if secret discovery or provider update check fails.
Preemptively remove any existing secret source before invoking
'secret source add' in registerSOPSSource to prevent duplicate
source registration errors across e2e test runs and retries. Use
sourceSubCmd constant to satisfy goconst lint rule, strip leading
slashes in repository relative path cleaner, and fallback to fetching
branches/unshallow when inspecting remote commit SHAs.
@skevetter skevetter closed this Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant