Skip to content

#1870: Add generic get-version implementation for global tools under windows - #1896

Closed
jakozian wants to merge 36 commits into
devonfw:mainfrom
jakozian:feature/#1870-generic-get-version-implementation-global-tools-windows
Closed

#1870: Add generic get-version implementation for global tools under windows#1896
jakozian wants to merge 36 commits into
devonfw:mainfrom
jakozian:feature/#1870-generic-get-version-implementation-global-tools-windows

Conversation

@jakozian

@jakozian jakozian commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR fixes #1870

Implemented changes:

  • Add logic in getInstalledVersion of GlobalToolCommandlet to look up tool in Windows registry.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

jakozian and others added 26 commits April 28, 2026 09:09
@jakozian
devonfw#1688: Remove unnecessary log messages
6d8e1fe
@jakozian
devonfw#1688: Add to CHANGELOG
a1f92f1
@jakozian
devonfw#1688: Override installation path getter to look in windows re…
3968af7 
…gistry
@jakozian
devonfw#1688: Fix installation flow and thus mention exception
6a1c228
@jakozian
devonfw#861: Add to CHANGELOG
3c5b463
@jakozian
devonfw#1869: Extract process of running reg into private method
faa6b1b
@jakozian
devonfw#1869: Extend WindowsHelper interface with methods to retrieve…
53fff3f 
… entries from registry
@jakozian
devonfw#1869: Add interface methods to WindowsHelperImpl
d123088
@jakozian
devonfw#1869: Add interface methods to WindowsHelperMock
7c8f432
@jakozian
devonfw#1869: Add test-seam class to simulate running of reg.exe command
9693b95
@jakozian
devonfw#1869: Add tests for WindowsHelperImpl
ccb14d3
@jakozian @MarvMa
Update cli/src/main/java/com/devonfw/tools/ide/os/WindowsHelperImpl.java
8b4d51d 
Co-authored-by: MarvMa <marvin.meitzner@gmail.com>
@hohwille
Merge branch 'main' into fix/devonfw#1688-remove-unnecessary-cli-mess…
a02ba1d 
…age-install-tool
@jakozian
Merge branch 'main' into fix/devonfw#1688-remove-unnecessary-cli-mess…
e1e9ff9 
…age-install-tool
@jakozian
Merge branch 'main' into fix/devonfw#861-exception-when-pgadmin-insta…
d391660 
…ll-wizard-starts
@jakozian
devonfw#1869: Replace string with constant
a35910b
@jakozian
Merge branch 'main' of https://github.com/devonfw/IDEasy into feature/d…
68e09fc 
…evonfw#1869-improve-windows-helper-to-search-windows-registry
@jakozian
Merge branch 'fix/devonfw#1688-remove-unnecessary-cli-message-install…
884919d 
…-tool' of https://github.com/jakozian/IDEasy into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows
@jakozian
Merge branch 'fix/devonfw#861-exception-when-pgadmin-install-wizard-s…
ce48e7e 
…tarts' of https://github.com/jakozian/IDEasy into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows

# Conflicts:
#	CHANGELOG.adoc
@jakozian
devonfw#1869: Change display name to display version
6ed1306
@jakozian
Merge branch 'feature/devonfw#1869-improve-windows-helper-to-search-w…
2e2223a 
…indows-registry' of https://github.com/jakozian/IDEasy into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows
@jakozian
devonfw#1869: Change search to find exact path first and the keys in …
2d40318 
…this path
@jakozian
Merge branch 'feature/devonfw#1869-improve-windows-helper-to-search-w…
8e37b3f 
…indows-registry' into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows
@jakozian
devonfw#1870: Add method for windows app name to super class of globa…
16446ab 
…l tools
@jakozian
devonfw#1870: Add logic to get version for global tools under windows
0e9a9d9
@jakozian
devonfw#1870: Fix mock logic of runReg
e05473a
@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board May 6, 2026
@jakozian jakozian self-assigned this May 6, 2026
@jakozian jakozian added the windows specific for Microsoft Windows OS label May 6, 2026
@jakozian

jakozian commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

Waiting for #1876 to get merged.

@jakozian
jakozian marked this pull request as ready for review May 7, 2026 07:50
@jakozian jakozian moved this from 🏗 In progress to Team Review in IDEasy board May 7, 2026
@MarvMa MarvMa self-assigned this May 7, 2026
@jakozian jakozian changed the title #1870: Implement generic get-version implementation for global tools under windows #1870: Add generic get-version implementation for global tools under windows May 7, 2026
@jakozian jakozian moved this from Team Review to 👀 In review in IDEasy board May 7, 2026
@jakozian
jakozian requested a review from hohwille May 7, 2026 13:36
@hohwille hohwille assigned hohwille and unassigned MarvMa and jakozian Jun 18, 2026
hohwille
hohwille reviewed Jun 22, 2026
View reviewed changes
Comment thread cli/src/test/java/com/devonfw/tools/ide/os/WindowsHelperImplTestable.java
@@ -0,0 +1,68 @@
package com.devonfw.tools.ide.os;

@hohwille hohwille Jun 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed. See PR #1876

hohwille
hohwille reviewed Jun 22, 2026
View reviewed changes
Comment thread cli/src/test/java/com/devonfw/tools/ide/os/WindowsHelperMock.java Outdated
hohwille
hohwille reviewed Jun 22, 2026
View reviewed changes
Comment thread cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java
*/
public String getWindowsRegistryAppName() {

return this.tool;

@hohwille hohwille Jun 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we also have to override this for Docker and some other tools to make it work?

@vivu001 vivu001 Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. This method should work for Docker and PgAdmin as well.

maybeec added 2 commits July 4, 2026 11:47
@maybeec
Merge remote-tracking branch 'origin/main' into feature/devonfw#1870-…
9f16cad 
…generic-get-version-implementation-global-tools-windows

# Conflicts:
#	CHANGELOG.adoc
@maybeec
Merge remote-tracking branch 'upstream/main' into feature/devonfw#1870-…
8a3edd1 
…generic-get-version-implementation-global-tools-windows

# Conflicts:
#	CHANGELOG.adoc
@hohwille hohwille removed their assignment Jul 21, 2026
@vivu001 vivu001 self-assigned this Jul 31, 2026
@vivu001 vivu001 mentioned this pull request Jul 31, 2026
Merged
7 tasks
@hohwille

hohwille commented Aug 3, 2026

Copy link
Copy Markdown
Member

Replaced by PR #2244

@hohwille hohwille closed this Aug 3, 2026
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Aug 3, 2026
@hohwille hohwille added this to the rejected milestone Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hohwille hohwille hohwille left review comments
+2 more reviewers
@vivu001 vivu001 vivu001 left review comments
@MarvMa MarvMa MarvMa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@vivu001 vivu001

Labels

commandlet ide sub-command windows specific for Microsoft Windows OS

Projects

IDEasy board
Status: ✅ Done

Milestone

rejected

Development

Successfully merging this pull request may close these issues.

Implement generic get-version implementation for global tools under windows

6 participants

@jakozian @coveralls @hohwille @MarvMa @vivu001 @maybeec