Repository navigation
compiler: Fix MPI data distribution for free surface use cases - #3105
Open
FabioLuporini wants to merge 10 commits into
Open
FabioLuporini wants to merge 10 commits into
FabioLuporini wants to merge 10 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3105 +/- ##
==========================================
- Coverage 84.52% 83.97% -0.56%
==========================================
Files 260 260
Lines 58599 58758 +159
Branches 4978 4988 +10
==========================================
- Hits 49532 49343 -189
- Misses 8240 8569 +329
- Partials 827 846 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mloubout
reviewed
Nov 5, 2026
| or len(np.unique(offsets, axis=0)) != len(offsets)): | ||
| return self.grid.distributor.glb_to_rank(self._support) or {} | ||
|
|
||
| # A tensor stencil intersects a Cartesian rank exactly when its |
Contributor
There was a problem hiding this comment.
given the condition above, this looks like a by hand "optimization" that i'm not sure warrants that much code
Contributor
Author
There was a problem hiding this comment.
simplified significantly
mloubout
reviewed
Nov 5, 2026
| def _support_indices(self): | ||
| # Staggered tables may use a different base cell across an MPI | ||
| # boundary. Match their fp64 geometry and actual stencil support. | ||
| spacing = np.array([as_fp64_decimal(h) for h in self.grid.spacing]) |
Contributor
There was a problem hiding this comment.
these should likely be grid properties
mloubout
reviewed
Nov 5, 2026
mloubout
reviewed
Nov 5, 2026
| @pytest.mark.parametrize('ndim', [1, 2, 3]) | ||
| @pytest.mark.parametrize('interpolation,radius', | ||
| [('nearest', 0), ('linear', 1), ('sinc', 4)]) | ||
| def test_tensor_support_rank_intersections(self, mode, ndim, interpolation, radius): |
Contributor
There was a problem hiding this comment.
don't understand what this actually ttests
FabioLuporini
force-pushed
the
fix/mpi-runtime-correctness
branch
from
November 5, 2026 17:25
8de2214 to
661aabc
Compare
mloubout
reviewed
Nov 6, 2026
mloubout
approved these changes
Nov 6, 2026
Select overlap candidates through their nearest enclosing Iteration, keeping exchanges outside loops synchronous. Replace the hand-built HaloSpot test with Operator-based structure and numerical checks for all three overlap modes on one and two ranks.
Extend the existing atomic_write helper with exclusive publication and use binary mode when restoring shared libraries. Keep text and header writes replacing by default, and cover cleanup and existing destinations.
Move both restoration regressions into TestLibraryPublication and remove the standalone module, preserving the existing assertions and fixtures.
Derive tensor support bounds directly from the radius and keep cell geometry in the interpolator. Preserve the interval optimization and test separate staggered support boxes.
FabioLuporini
force-pushed
the
fix/mpi-runtime-correctness
branch
from
November 8, 2026 11:07
b1f8d3b to
9b1c076
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
also a bunch of extra minor tweaks