Skip to content

compiler: Support split-buffer option at arg_check - #3083

Open
FabioLuporini wants to merge 6 commits into
mainfrom
split-time-funcs
Open

FabioLuporini wants to merge 6 commits into
mainfrom
split-time-funcs

Conversation

@FabioLuporini

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.63866% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.86%. Comparing base (bf0784c) to head (fb057de).

Files with missing lines Patch % Lines
devito/types/dense.py 40.00% 1 Missing and 2 partials ⚠️
devito/core/gpu.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3083      +/-   ##
==========================================
- Coverage   84.51%   83.86%   -0.65%     
==========================================
  Files         260      260              
  Lines       58458    58554      +96     
  Branches     4964     4970       +6     
==========================================
- Hits        49403    49107     -296     
- Misses       8226     8592     +366     
- Partials      829      855      +26     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.46% <57.69%> (-0.01%) ⬇️
pytest-gpu-gcc- 79.27% <96.63%> (+0.04%) ⬆️
pytest-gpu-icx- 79.19% <96.63%> (+0.02%) ⬆️
pytest-gpu-nvc-nvidiaX ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tests/test_linearize.py Outdated
with pytest.raises(InvalidArgument, match='int32 pointer arithmetic'):
op.arguments(u=data, time_m=0, time_M=2)
else:
op.arguments(u=data, time_m=0, time_M=2)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought we said it's illegal to provide array as kwargs to apply

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover from obsolete PR, will tweak

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@FabioLuporini
FabioLuporini force-pushed the split-time-funcs branch 4 times, most recently from ed3d476 to 1a05cb1 Compare October 27, 2026 16:16
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@FabioLuporini

Copy link
Copy Markdown
Contributor Author

Now this one to go in after #3084

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants