compiler: Avoid CSE capture of opaque DefFunction calls - #3004
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3004 +/- ##
=======================================
Coverage 83.63% 83.63%
=======================================
Files 257 257
Lines 54221 54235 +14
Branches 4629 4629
=======================================
+ Hits 45349 45361 +12
- Misses 8074 8076 +2
Partials 798 798
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSE registers
sympy.Functionapplications as candidates, so an opaque C-level call (DefFunction) appearing verbatim on several right-hand sides gets captured into aCTemp. The temporary's dtype comes fromextract_dtype, which only sees the call's free symbols — for a call likemake_float4(r1, r1, r1, r1)(emitted downstream when vector types are in play) that isfloat32, so the generated code declareswhich nvcc rejects (
no operator "=" matches these operands: float4 = float; observed ascodepy.CompileErroron staggered/TTI elastic adjoint operators on GPU with vector types enabled).This adds a
_catchhandler that leavesDefFunctions uncaptured: their return dtype is invisible to the type inference, and, being opaque calls, they are not guaranteed to be pure either.