api: introduce nearset neighboor interpolation and assignment injection for it - #3003
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3003 +/- ##
==========================================
+ Coverage 83.60% 83.61% +0.01%
==========================================
Files 257 257
Lines 54114 54185 +71
Branches 4622 4626 +4
==========================================
+ Hits 45241 45307 +66
- Misses 8075 8080 +5
Partials 798 798
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mloubout
force-pushed
the
no-incr-inject
branch
from
August 13, 2026 04:41
2ce08c9 to
3c52121
Compare
EdCaunt
reviewed
Aug 13, 2026
| implicit_dims = implicit_dims + tuple(r.parent for r in | ||
| self._rdim(subdomain=subdomain, | ||
| shifts=shifts)) | ||
| with suppress(AttributeError): |
Contributor
There was a problem hiding this comment.
In what case would an attribute error be expected here?
Contributor
Author
There was a problem hiding this comment.
Nearest has "empty" rdim so doesn't have a parent attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.