Repository navigation
feat(devices): flag stale discovered pane data and show AMT DNS suffix - #3701
Open
ShradhaGupta31 wants to merge 1 commit into
Open
ShradhaGupta31 wants to merge 1 commit into
ShradhaGupta31 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The pane hides DNS suffixes when deviceInfo is absent and fails to show a load warning after HTTP 504 responses, with regression coverage needed for both cases.
2 open issues
What changed in this PR
This PR updates the discovered-device details pane to address Console issue #1377, adding a stale-data warning and displaying the AMT DNS suffix when available.
Changes:
- Tracks detail-fetch failures and displays an alert while retaining cached details.
- Adds the AMT DNS suffix row and translations for all 12 supported locales.
- Adds unit tests for error-state handling and suffix display.
| File | Description |
|---|---|
| src/assets/i18n/sv.json | Adds Swedish warning and suffix label. |
| src/assets/i18n/ru.json | Adds Russian warning and suffix label. |
| src/assets/i18n/nl.json | Adds Dutch warning and suffix label. |
| src/assets/i18n/ja.json | Adds Japanese warning and suffix label. |
| src/assets/i18n/it.json | Adds Italian warning and suffix label. |
| src/assets/i18n/he.json | Adds Hebrew warning and suffix label. |
| src/assets/i18n/fr.json | Adds French warning and suffix label. |
| src/assets/i18n/fi.json | Adds Finnish warning and suffix label. |
| src/assets/i18n/es.json | Adds Spanish warning and suffix label. |
| src/assets/i18n/en.json | Adds English warning and suffix label. |
| src/assets/i18n/de.json | Adds German warning and suffix label. |
| src/assets/i18n/ar.json | Adds Arabic warning and suffix label. |
| src/app/devices/discovered-device-pane/discovered-device-pane.component.ts | Adds error input and AMT DNS suffix row. |
| src/app/devices/discovered-device-pane/discovered-device-pane.component.spec.ts | Tests warning visibility, cached details, and suffix display. |
| src/app/devices/discovered-device-pane/discovered-device-pane.component.scss | Styles the error alert. |
| src/app/devices/discovered-device-pane/discovered-device-pane.component.html | Renders the alert and suppresses the empty message on failure. |
| src/app/devices/devices.component.ts | Tracks and resets pane fetch-error state. |
| src/app/devices/devices.component.spec.ts | Tests fetch-error state and reset behavior. |
| src/app/devices/devices.component.html | Passes error state to the pane. |
Review effort: Balanced
ShradhaGupta31
force-pushed
the
feat/pane-load-error-dns-suffix
branch
from
November 10, 2026 06:15
6131f66 to
ffca64a
Compare
- If fetching the latest copy of a discovered device fails, the pane now shows an error saying the details may be out of date. - The pane also shows the AMT DNS suffix when the API returns one. Strings are added for all supported locales. Resolves: device-management-toolkit/console#1377 Signed-off-by: ShradhaGupta31 <shradha.gupta@intel.com>
ShradhaGupta31
marked this pull request as ready for review
November 10, 2026 06:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #3612
Resolves: device-management-toolkit/console#1377
PR Checklist