Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Both dependency manifests require a missing tarball, blocking clean npm ci installs; retaining it also requires copying it into the Docker build before installation.
1 open issue
What changed in this PR
Adds selectable Serial Over LAN (SOL) character encoding to help diagnose BIOS display issues, paired with the ui-toolkit decoding POC.
Changes:
- Adds PC-ANSI/CP437 and UTF-8 selection before connecting, with encoding retained across reconnects.
- Adds connection guidance, OEM handshake diagnostics, reconnect cancellation, and unit tests.
- Adds localized messages and a local toolkit tarball dependency.
| File | Description |
|---|---|
| src/assets/i18n/sv.json | Adds Swedish encoding and connection guidance. |
| src/assets/i18n/ru.json | Adds Russian encoding and connection guidance. |
| src/assets/i18n/nl.json | Adds Dutch encoding and connection guidance. |
| src/assets/i18n/ja.json | Adds Japanese encoding and connection guidance. |
| src/assets/i18n/it.json | Adds Italian encoding and connection guidance. |
| src/assets/i18n/he.json | Adds Hebrew encoding and connection guidance. |
| src/assets/i18n/fr.json | Adds French encoding and connection guidance. |
| src/assets/i18n/fi.json | Adds Finnish encoding and connection guidance. |
| src/assets/i18n/es.json | Adds Spanish encoding and connection guidance. |
| src/assets/i18n/en.json | Adds English encoding and connection guidance. |
| src/assets/i18n/de.json | Adds German encoding and connection guidance. |
| src/assets/i18n/ar.json | Adds Arabic encoding and connection guidance. |
| src/app/devices/sol/sol.component.ts | Applies encoding, captures diagnostics, and cancels queued reconnects. |
| src/app/devices/sol/sol.component.spec.ts | Tests encoding selection, connection states, diagnostics, and retry cancellation. |
| src/app/devices/sol/sol.component.scss | Styles the SOL card, selector, and guidance. |
| src/app/devices/sol/sol.component.html | Adds the encoding selector and guidance in a Material card. |
| README.md | Documents POC usage, diagnostics, and dependency setup. |
| package.json | Adds the local toolkit tarball dependency. |
| package-lock.json | Locks toolkit resolution to the local tarball. |
Review effort: Balanced
| "@angular/core": "~22.2.4", | ||
| "@angular/forms": "~22.2.4", | ||
| "@angular/material": "~22.2.2", | ||
| "@device-management-toolkit/ui-toolkit": "file:device-management-toolkit-ui-toolkit-3.3.22.tgz", |
Contributor
Author
There was a problem hiding this comment.
this will be removed when the ui-toolkit changes are merged. Needed for testing currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is associated with the POC to test adding UTF-7 and PC-ANSI/CP437 options for SOL to fix the decoding issues when displaying the BIOS. It's to be used with the ui-toolkit PR: device-management-toolkit/ui-toolkit#1901