Repository navigation
Docs: #452 の構造の決定を確定仕様へ移し、作業文書を消す - #496
Merged
Merged
Conversation
- cli-argument-resolution.md: bash の補完の語の位置での振り分け・_devbase_resolve_root、 zsh の profile の分岐を関数へ寄せない理由(一致テストが case を字面で辿る)を足す - base-image-contents.md: tests/containers の共通の部品(run_blocks・image_unavailable)を足す - issues/issue-452-design.md・issues/issue-452-requirements.md を消す Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NjbAm85zNM1QmoDYNiX5Dy
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
スプリント m8e(#495)の確定仕様化。#452 の設計の決定のうち、以後の判断の前提になるものを既存の確定仕様へ移し、作業文書を消す。#365・#490 は作業文書が無く、#490 が触る
docs/specifications/vscode-server-volume.mdは #495(7b95548)で直し済み。変更
docs/specifications/cli-argument-resolution.md_devbase_resolve_rootが呼び出し元のlocal devbase_rootへ入れる理由(決定 6)。補完を実行するテストの補助の置き場(決定 8)。zsh のprofileの分岐を関数へ寄せない理由(決定 5、R8 を直さない理由)docs/specifications/base-image-contents.mdtests/containers/の共通の部品run_blocks(dockerfile_parse.py)とimage_unavailable(docker_images.py)(決定 11)issues/issue-452-design.md・issues/issue-452-requirements.md確定仕様へ移さなかったもの:
check_group_optionをコマンドの層に置く)はsecret-backend.mdに既に書いてある_mask_env_noneの名前)・R7(SnapshotManager.listは基準の内)は、以後の判断の前提にならない_aws_whole_plan・CONTAINER_HOME)は実装の細部で、振る舞いの仕様ではない。vscode-server-volume.mdの定数の行は、置き場と値が変わらないため直さない(決定 4 のとおり)glossary.jsonに PR #450 の構造改善で時間の枠を超えて見送った提案の残り 15 件(_aws_plan の重複・補完の分岐の連なり・テストの補助の重複など) #452 の設計を出所とする語は無い(grep -c 452 docs/glossary/glossary.jsonは 0)設計の決定と違えたところ
無し(文書だけの変更)。
テスト
etc/devbase-completion.bashの関数はすべて 60 行以下、_devbase_complete_subcommandsが最長の 50 行)を main(94b5431)のコードと照合したpython3 .github/scripts/proper_term_check.pyは語の一覧が無い端末のため飛ばした(検査はしていない)。足した文に固有の語は無い🤖 Generated with Claude Code
https://claude.ai/code/session_01NjbAm85zNM1QmoDYNiX5Dy