Repository navigation
harden helm pending checks and CRD coverage - #82
Merged
Merged
Conversation
- reject pending releases with typed Status.IsPending before chart prep - add CRD lifecycle e2e plus chart-cache and install-order unit tests - document CRD failure modes and tighten the Helm abstraction note
github-actions
Bot
added
kind/docs
atkrad
added
kind/bug
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stuck pending Helm releases were detected with string matching in
wrapHelmError. That is fragile.Reject them with a typed
Status.IsPendingcheck before chart prep. Add CRD lifecycle e2e, chart-cache key tests, and install-after-CRD unit coverage. Document CRD non-atomic failure modes.