Repository navigation
Conversation
…de 1.0.229
sha2 0.11's digest output array no longer implements LowerHex, so the
manifest-format hex strings now go through one hex_encode helper instead
of format!("{:x}", digest). Output format is unchanged (lowercase hex,
no separators), which the signed-manifest verification tests cover.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Applies the five open dependabot bumps in one commit (bot PRs #10–#14 can be closed — Sami prefers no bot contributors):
One code change: sha2 0.11's digest output array no longer implements
LowerHex, so the threeformat!("{:x}", digest)sites (plus one in the topology test) now share onehex_encodehelper. Output format is byte-identical (lowercase hex, no separators) — that's what signed-manifest hash comparison depends on, and the update tests cover it.Evidence
cargo test --all-features→ all suites pass except one pre-existing flake on main:concurrent_writes_leave_a_complete_private_token_and_no_temp_files(token temp-name race,AlreadyExistson pid+nanos temp names). Verified it fails identically with my changes stashed onc1600ee, and passes in isolation 6/6. Filed as token_file: concurrent write_token races on temp name (flaky test on main) #24.cargo clippy --all-features --all-targets→ 0 warnings.closes #10
closes #11
closes #12
closes #13
closes #14
-kimi