Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Data apps can now page through DataFrames stored in the project, without running the notebook. A notebook block stores a frame with deepnote-toolkit's
store_dataframe(df, '<name>'), and the page reads it a page at a time withDeepnote.connect().dataframe('<name>', {pageIndex, pageSize}). This PR teaches thedeepnote-data-appsskill to use them.SKILL.md, The Notebook:create_run, then check the reference ID the block returned. Read-only runs, viewers' runs included, store nothing.pd.DataFrame(df)of a 100-row query preview.SKILL.md, The Page:Deepnote.connect()client, used for both the notebook anddataframe().int64anddecimalvalues arrive as strings: convert them, keepnull, and keep ID columns as strings.appData(). A page that shows only stored frames calls neitherappData()norrun().SKILL.md, Testing: the preview command takes--project-id.scripts/app-dev.mjs: a required--project-idoption, checked to be a UUID and sent asprojectIdin the token reply.dataframe()builds its URL from that ID, and without it the client rejects with "Reload the page to read dataframes."Hold
Keep this as a draft until
https://deepnote.com/static/app-client/v1.jscontainsReload the page to read dataframes.Today it doesn't, so the hosted client has nodataframe()yet.Testing
app-dev.mjswithout--project-idexits 1 and prints the usage, which documents the option. A non-UUID value exits 1 with an error. With a valid ID, the stand-in page's token reply includesprojectId.create_run, mint a token, run the preview with--project-id, and check that the bar reads "Connected to Deepnote. No app errors." and that the page showsrowCount2500 andpageCount3.