chore: Core C++ client README for coding agents and humans - #8317
Open
jcferretti wants to merge 2 commits into
Open
chore: Core C++ client README for coding agents and humans#8317jcferretti wants to merge 2 commits into
jcferretti wants to merge 2 commits into
Conversation
jcferretti
added
NoDocumentationNeeded
NoReleaseNotesNeeded
Contributor
No docs changes detected for c4fccb9 |
kosak
reviewed
Aug 14, 2026
kosak
left a comment
kosak
left a comment
Contributor
There was a problem hiding this comment.
Wow, someone did a lot of work on this. Was this you or you+Claude? Amazing.
Some nits below
| - `TableHandleManager::InputTable(initial_table, keys)` creates the input table *and* immediately | ||
| `AddTable`s the initial contents. | ||
| - `Aggregate::Count`, `aggCount`, `aggMax`, `aggMin`, `aggSum`, `aggCombo` are the surviving | ||
| lowercase legacy spellings; the rest are `CamelCase`. |
Contributor
There was a problem hiding this comment.
we should probably fix these
Member
Author
There was a problem hiding this comment.
That makes sense but I think that should be a followup PR, I can ask claude to do that and send you the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.